After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755378 - Bookmarks GUI refresh
Bookmarks GUI refresh
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 739633 (view as bug list)
Depends on: 109343 110583 110586 110841 111609 116479 116769 116771 122682 124077 143016 145480 148403 149379 150833 301950 307969 312221 313792 319150 332900 333826 334556 335572 335573 336274 336535 336559 337297 339304 344092 350853 351100 351470 351975 353911 374584 385143 406996 424464 465307 475435 491532 491858 519167 528634 567516 575108 617388 665536 671503 679908 695282 696398 699510 703365 703423 703425 707504 723217 723977 738212 739633 741867
Blocks: 755687
 
 
Reported: 2015-09-22 00:38 UTC by Diogo Campos
Modified: 2016-09-28 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bookmarks GUI mockup v1 (182.99 KB, image/png)
2015-09-22 00:38 UTC, Diogo Campos
Details
Bookmarks GUI mockup v2 (335.64 KB, image/png)
2015-09-23 07:18 UTC, Diogo Campos
Details
Bookmarks GUI mockup v3 (267.57 KB, image/png)
2015-09-25 01:56 UTC, Diogo Campos
Details

Description Diogo Campos 2015-09-22 00:38:18 UTC
Created attachment 311813 [details]
Bookmarks GUI mockup v1

Not exactly "needed" ( like Bug 755292 ), but I was told to open a bug anyway.
Hope you don't mind.

The purpose (for now, at least) is to make the actions related to bookmarks be more obvious and simple; while trying to reuse GNOME( Web) current design patterns, and trying to make few changes as possible.

See attachment.
Comment 1 Michael Catanzaro 2015-09-22 02:14:44 UTC
Looks good!
Comment 2 Diogo Campos 2015-09-22 09:14:00 UTC
Legitimate doubt: this "smart-bookmarks" feature is already a thing of the past, in GNOME Web 3.18?

Feedback needed: in a instant-filter and search-centered world, tags (topics) are still a useful thing?
Comment 3 Bastien Nocera 2015-09-22 09:59:51 UTC
(In reply to Diogo Campos from comment #2)
> Legitimate doubt: this "smart-bookmarks" feature is already a thing of the
> past, in GNOME Web 3.18?
> 
> Feedback needed: in a instant-filter and search-centered world, tags
> (topics) are still a useful thing?

For me, they are. Not so much because I prefer "folders" but I can add tags without changing the title. Google Bookmarks uses tags as well (https://www.google.com/bookmarks).
Comment 4 Michael Catanzaro 2015-09-22 13:11:07 UTC
(In reply to Diogo Campos from comment #2)
> Legitimate doubt: this "smart-bookmarks" feature is already a thing of the
> past, in GNOME Web 3.18?

No, they still exist and they're useful, but completely undiscoverable. There is a section on how to use them in the user help.
Comment 5 Diogo Campos 2015-09-22 15:53:32 UTC
(In reply to Michael Catanzaro from comment #4)
> No, they still exist and they're useful, but completely undiscoverable.
> There is a section on how to use them in the user help.

hmm... they are like "custom search providers"...
Comment 6 Diogo Campos 2015-09-23 07:18:02 UTC
Created attachment 311921 [details]
Bookmarks GUI mockup v2

I'm still not happy about it. But I'm posting it here for feedback purposes.

Changelog:

Informed that 'Bookmarks' should be removed from the 'Hamburguer Menu'.
Changed the visual states of the 'Bookmark Button'.
Added 'Smart Bookmark' UI content (and UI hint).
Added 'Tags/Topics' management UI.
Comment 7 Allan Day 2015-09-23 14:09:21 UTC
There's definitely some interesting ideas here! I think I'd be interested in discussing some of the major design questions, like what the goals are. Maybe we could do that on IRC?
Comment 8 Michael Catanzaro 2015-09-23 14:59:59 UTC
Another requirement is to support some sort of bookmark sync solution. There have been many requests for Firefox Sync; I think we should go with that, so long as Mozilla lets us use their server. (I haven't looked up their terms of use.)

OwnCloud Bookmarks have also been requested. I think that would be lower priority, because it would require setting up your own OwnCloud server, as far as I understand it.
Comment 9 Diogo Campos 2015-09-23 20:35:20 UTC
(In reply to Allan Day from comment #7)
> There's definitely some interesting ideas here! I think I'd be interested in
> discussing some of the major design questions, like what the goals are.
> Maybe we could do that on IRC?

English and real-time for me are a bit problematic (especially together). I would prefer direct e-mail (or mailing list). But, sure, you can ping me on IRC if you see me.
Comment 10 Diogo Campos 2015-09-23 20:52:06 UTC
(In reply to Michael Catanzaro from comment #8)
> Another requirement is to support some sort of bookmark sync solution. There
> have been many requests for Firefox Sync; I think we should go with that, so
> long as Mozilla lets us use their server. (I haven't looked up their terms
> of use.)
> 
> OwnCloud Bookmarks have also been requested. I think that would be lower
> priority, because it would require setting up your own OwnCloud server, as
> far as I understand it.

Since it may be possible to synchronize more than bookmarks (history, passwords, tabs?), I added the 3 sync-related bugs that I found to Bug 755292.
Comment 11 Claudio Saavedra 2015-09-24 09:22:28 UTC
Before we get too carried away, let's keep in mind that originally we wanted to integrate "favorites/bookmarked" sites in the overview somehow. I'd take that into consideration too.
Comment 12 Michael Catanzaro 2015-09-24 17:38:45 UTC
*** Bug 739633 has been marked as a duplicate of this bug. ***
Comment 13 Diogo Campos 2015-09-25 01:56:03 UTC
Created attachment 312106 [details]
Bookmarks GUI mockup v3

Changelog:

Removed Location Bar content (see Bug 755518).
Removed Menus references (see Bug 755524).
Comment 14 Michael Catanzaro 2015-11-19 19:07:13 UTC
Here's a mockup from Allan: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/web/web-header-bar-wires.png

It looks like bookmarks could be managed simply from that bookmarks menu, without need for the full bookmarks dialog or even the bookmark property editor dialog.
Comment 15 Allan Day 2015-11-20 10:09:56 UTC
(In reply to Michael Catanzaro from comment #14)
> Here's a mockup from Allan:
> https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/web/
> web-header-bar-wires.png

Note that this is a first draft and hasn't been discussed with anyone yet.
 
> It looks like bookmarks could be managed simply from that bookmarks menu,
> without need for the full bookmarks dialog or even the bookmark property
> editor dialog.

There are two reasons for this: 1. There needs to be a way to quickly access bookmarks for navigation purposes. 2. I wanted to avoid there being multiple UIs for bookmarks (such as Firefox where you have the drop down from the toolbar, the bookmarks sidebar, and a separate dialog for bookmark management).
Comment 16 Michael Catanzaro 2015-12-08 16:17:07 UTC
Allan has updated his mockup in comment #14.

After discussing it at today's Epiphany team meeting, we're concerned the popover-based design won't scale well when the user has a large number of bookmarks. One interesting proposal was to use the entire web view to display bookmarks, as we do for the overview, but we don't have any design proposals for this.
Comment 17 Allan Day 2015-12-08 17:34:37 UTC
(In reply to Michael Catanzaro from comment #16)
> Allan has updated his mockup in comment #14.
> 
> After discussing it at today's Epiphany team meeting, we're concerned the
> popover-based design won't scale well when the user has a large number of
> bookmarks.

Is this because of the popover's height? Maybe we should speak to the GTK+ developers about automatic popover resizing?

> One interesting proposal was to use the entire web view to
> display bookmarks, as we do for the overview, but we don't have any design
> proposals for this.

This doesn't cater well to the quick launch use case for bookmarks (as you commonly see with bookmark bars) - using an entire web view is a big transition and involves a heavy cognitive burden as a result.

It also somewhat depends on whether you are going to represent bookmarks as thumbnails or as a list - a list would leave most of the web view empty (like in Chrome's bookmark manager). Note that Chrome's attempt to use a grid view did not go down well with users... [1] :)

[1] http://thenextweb.com/google/2015/06/15/google-is-ripping-out-chromes-awful-new-bookmark-manager/
Comment 18 Michael Catanzaro 2016-09-28 15:50:47 UTC
There is nothing remaining of the previous bookmarks UI, so the GUI has certainly been refreshed and I think this can be closed. I'll be reviewing the blocking bugs separately.