After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696398 - Useless selection window when importing bookmarks
Useless selection window when importing bookmarks
Status: RESOLVED WONTFIX
Product: epiphany
Classification: Core
Component: Bookmarks
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755378
 
 
Reported: 2013-03-22 15:20 UTC by Michael Catanzaro
Modified: 2016-10-07 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This combo box has only one option (7.30 KB, image/png)
2013-03-22 15:20 UTC, Michael Catanzaro 		Details

Description Michael Catanzaro 2013-03-22 15:20:23 UTC 
Created attachment 239554 [details]
This combo box has only one option

In Epiphany 3.6.1 or 3.7.92, select "Bookmarks" from the application menu and then hit "Import Bookmarks."  A window pops up asking the user to select where to import bookmarks from, but the only option is "File."  ("Firefox" was an option in Epiphany 3.4.x, but it didn't work.)  This window should not be displayed at all unless there are at least two import options to select from.
Comment 1 Xan Lopez 2013-03-22 15:40:38 UTC 
The list is constructed at runtime given how many bookmarks sources we are able to find. If you have Firefox bookmarks in your system but they do not show up in the list it means our source locations are outdated.
Comment 2 Xan Lopez 2013-03-22 15:44:21 UTC 
I guess the issue you are raising is that if we cannot find *any* source we should not offer a Combobox with just one option. I guess we could just change it for a label explaining that we could not automatically detect bookmarks files in the system and asking the user to go ahead and give us one.
Comment 3 Xan Lopez 2013-03-22 15:50:01 UTC 
I guess the issue you are raising is that if we cannot find *any* source we should not offer a Combobox with just one option. I guess we could just change it for a label explaining that we could not automatically detect bookmarks files in the system and asking the user to go ahead and give us one.
Comment 4 Michael Catanzaro 2013-03-22 20:36:49 UTC 
Yeah that sounds good.

(I do have Firefox bookmarks, though.  They might be a subset of my Epiphany bookmarks, not sure if that matters or not.)
Comment 5 Michael Catanzaro 2016-09-28 16:49:46 UTC 
Hi, the bookmarks code has been rewritten from scratch. When you have a convenient opportunity to test the new version of the code (which will be present in Epiphany 3.23.1) please check to see if your issue is still a problem, and reply here. Thanks!
Comment 6 Michael Catanzaro 2016-10-07 21:28:12 UTC 
Hi, this is a mass close of all bugs in the NEEDINFO state. If you think this bug was closed improperly, just leave a comment, thanks!