GNOME Bugzilla – Bug 109343
ui for preventing user from creating two topics with the same name
Last modified: 2016-09-28 16:02:08 UTC
popup a modal dialog if the user tries to create/rename a keyword that already exists (case insensitively)
Why not let the user do it if he wants ? Just a question ;)
Well having more than one topic with the same name is going to be pretty confusing don't you think. So for the case sensitive case, I really think there needs to be some sort of warning you can't do that. The case insensitive case is more "contravertial." I really like how the mac file system is case insensitive, but case preserving. I think presenting the ephy bookmark database similarly is a good idea. Hence having two topics with the same name is still odd... Of course maybe i'm just being anal retentive.
daveb> xan well technically you can have more than one topic with the same name right now, but i consider that a bug <xan> nod <xan> didn't know about that <xan> is there a bug filled? <daveb> yeah its obxcure, i filed one a while ago <-- reinouts_ (reinout@sloep110.cs.vu.nl) has left #epiphany <daveb> we should probably just popup an info dialog saying you can't do that <xan> yes, should be very easy to fix :) <mpt> an Evil Alert <mpt> attack earlier <mpt> as early as possible --> menthos (~menthos@as2-4-1.for.hs.bonet.se) has joined #epiphany --- EphyBot gives channel operator status to menthos <mpt> In the UI for specifying the name itself <daveb> mpt yeah like rename a file <mpt> put up a tiny wee "/!\ Sorry, that name is already taken" <mpt> *right under the text field* <daveb> xan can we do that? <mpt> which appears when the name is the same as an existing one, and disappears as soon as it's not <daveb> good idea :) <mpt> and disables the OK (or whatever) button whenever it appears <xan> with inline editing? no idea <daveb> hmm <mpt> P.S. I'm not drunk, I'm just very very tired. <daveb> mpt nod <xan> what it would be, and where it would be? <daveb> xan could be a tooltip <mpt> daveb: That means, I guess, you need to have some fancy callback thingy which works after every keypress <mpt> xan might be a tooltip, but this thing wouldn't be <mpt> this would appear no matter where the mouse was <mpt> right under the text field <xan> and it disables enter <mpt> roight. <daveb> and we could just not exit renaming if the name is the same <mpt>Just an ordinary caption, which happens to have a special icon /!\
Sorry for the spam. Reassigning bugs with a target to our next milestone.
One problem with multiple topics with the same name is that when you place one of them in the toolbar, the toolbar layout file saves that as topic://Topicname -- so on next load it's totally unclear which of those topics with the same name it will choose [the first one will win, but the _user_ doesn't know that.]
Since this uses in place editing in a table, where would you suggest such a message should go? Also, is it possible to not allow editing to end in a GtkTreeView tex editor?
Target: 1.2 -> 1.4
Mass-moving Target 1.4 -> 1.6 because of feature and UI freeze. Sorry for the bugspam, search for "mass-move-1.4-1.6" to filter all of it.
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Mass-moving bugs from Target Milestone: 1.6 to 1.8 because of feature, UI and string freeze.
Target: 1.8 -> 1.10 due to feature and UI freeze.
Why not simply silently merge them? That is what happens basically right now.
cc'ing harves...
Whatever solution we come up, with we should use the same for resolving duplicates in the bookmarks properties window. Perhaps we can agree on a "warning" widget to be placed on all properties dialogs where consistency issues may arise? The idea has been floated a number of times. Something like "a button which is hidden unless there is a consistency problem" (duplicate name, etc) and which gives you options to resolve the inconsistency if it's clicked. Mind you, the Gnome standard of "apply all changes immediately" makes enforcing consistency very difficult.
There is a partial fix for this in CVS. It's not the best, and so I don't want to close this bug yet.
In the Bookmarks editor, it is still possible to create two topics with the same name.
Still valid.
Hey, I'm interested in fixing this bug, but I can't find any agreed-upon solution. What about using a modal dialog or popover, as in nautilus?
Juraj, I am trying a "Bookmarks refresh" thing in the Bug 755378. BUT, if you don't want to wait (or if you simply don't care), I think that something similar to Nautilus would be excellent.
If the code could be reusable in the new design, I will gladly try. It'll be my first UI contribution so it might take some time, but it'll be hopefully worth it.
Well, the bookmarks dialog itself is probably going to need to be simply deleted and started from scratch. But you can also create topics from the bookmark properties and new bookmark dialogs, which are already fine and can be kept.
(In reply to Juraj Fiala from comment #21) > If the code could be reusable in the new design, I will gladly try. It'll be > my first UI contribution so it might take some time, but it'll be hopefully > worth it. Nautilus's 'Rename' and 'New Folder' UI patterns are great. They should (and, probably, will) be reused. So, if you will enjoy, go ahead :)
On it! Just give me some time to figure out how the thing actually works please (:
Button changes to insensitive now