GNOME Bugzilla – Bug 728002
Port to WebKit2
Last modified: 2017-02-28 14:45:57 UTC
I've been informed by a member of the WebKit team that WebKit 1 has been officially end-of-lifed. We need to prioritize moving to WebKit 2. One of the big tasks is that we'll need to build a shared object (essentially a .so) that's loaded by the rendering process and communicates via IPC (D-bus makes sense here) with Geary.
*** Bug 734312 has been marked as a duplicate of this bug. ***
This will also bring High-DPI support for the message view!
There is a test case here: https://github.com/rschroll/webkitdom Note that we needed to fix a WebKit VAPI file to make the DOM event handlers work. This will presumably make it into Vala 0.26.2. Until we can require that, I guess we have to build our own VAPI files.
Another potential way to work around this is to use extern declarations. Not pretty, but one way to work around VAPI issues if only a couple of methods are problematic.
*Bump* There are many issues with WebKit 1 Gtk bindings. Please port your code to WebKit 2 Gtk bindings. See https://blogs.gnome.org/mcatanzaro/2016/02/01/on-webkit-security-updates/ for reasons why.
*** Bug 741866 has been marked as a duplicate of this bug. ***
WIP up and running here: https://github.com/mjog/geary/tree/wip/widget-conversation-viewer I'm concentrating on converting to using GTK for displaying individual messages first, where each message in a convo has its own WebKit.WebView. Once that's up to speed, then porting to WebKit2 will be much easier. More details of the approach in commit messages for that branch. I'm using GitHub while I don't have a GNOME account.
Sounds good - I'm glad to hear this is underway!
The fix for Bug 765516 is going to land in the next couple of days, so I'll picking this up this soon. There are some unfinished issues from that bug that weren't worth fixing until we have ported to WK2, and hence should be fixed as part of this. These include: * Known crashers: - In libsoup when rapidly changing conversations - Displaying some excessively long emails with a wide screen - Replying to very long emails * Email height related issues: - Space bar no longer advances through a conversation by page - ListBox jumping around when rows are focused by a click - Very long emails being truncated - Message web view not resizing when it shrinks in height - Implement ConversationListBox::get_selection_view properly * Message display: - Cannot re-collapse quotes - Link warning popover position occasionally incorrect - Message headers are not being printed * Composer: - Clamp top of embedded composer toolbar to top of list box window & bottom to the bottom * Search: - Reenable next/prev for find - Scroll to first matching message
Okay, I've started a branch for this and will be pushing it up to GNOME git at wip/728002-webkit2 as it evolves. It's terribly broken at the moment, this is more of a backup and in case anyone is interested, but will be improving over time.
I confirm the "cannot re-collapse quotes" (a bit annoying). Another bug (I think): I can no longer mark as special a folded message. The star is visible but greyed out and if I click on it nothing happens; I have to unfold the message and then the click works.
(In reply to Federico Bruni from comment #11) > I confirm the "cannot re-collapse quotes" (a bit annoying). This should be fixed, but it's a bit clunky still - I'll look at refining it a bit. > Another bug (I think): I can no longer mark as special a folded message. The > star is visible but greyed out and if I click on it nothing happens; I have > to unfold the message and then the click works. Were we discussing this ages ago, on the list maybe? Anyway, this actually by design - the idea being that you probably want to be looking at the message before you decide to star/reply/print/etc it. If it's annoying, and not what 0.11 and earlier let you do, please open a new bug and we can flesh out some use cases and design issues there.
Fixed on master with commit 29b339c. I'll open bugs for the outstanding issues I mentioned in comment #9 above that are yet to be addressed.
\o/
(In reply to Michael Gratton from comment #12) > (In reply to Federico Bruni from comment #11) > > I confirm the "cannot re-collapse quotes" (a bit annoying). > > This should be fixed, but it's a bit clunky still - I'll look at refining it > a bit. > Yes, it's fixed. > > Another bug (I think): I can no longer mark as special a folded message. The > > star is visible but greyed out and if I click on it nothing happens; I have > > to unfold the message and then the click works. > > Were we discussing this ages ago, on the list maybe? Anyway, this actually > by design - the idea being that you probably want to be looking at the > message before you decide to star/reply/print/etc it. If it's annoying, and > not what 0.11 and earlier let you do, please open a new bug and we can flesh > out some use cases and design issues there. Actually I'm not 100% sure that 0.11 and earlier let you do so. Anyway, the current idea makes sense, so I won't open a new bug for this. We'll see if other people will be annoyed by this behaviour (I'm not).