GNOME Bugzilla – Bug 712926
Geary relies on undo to decide whether to warn the user about closing a ComposerWindow
Last modified: 2017-02-01 00:03:20 UTC
---- Reported by geary-maint@gnome.bugs 2012-06-14 12:26:00 -0700 ---- Original Redmine bug id: 5404 Original URL: http://redmine.yorba.org/issues/5404 Searchable id: yorba-bug-5404 Original author: Matthew Pirocchi Original description: This wouldn't normally be a problem, but because undo is broken, this can lead to Geary incorrectly failing to warn the user. This issue will be closed if #5388 is closed. In the meantime, perhaps there should be a workaround. Related issues: related to geary - 5388: Pressing enter inside a blockquote breaks undo (Open) ---- Additional Comments From geary-maint@gnome.bugs 2013-04-03 18:08:00 -0700 ---- ### History #### #1 Updated by Adam Dingle over 1 year ago * **Priority** changed from _Normal_ to _High_ #### #2 Updated by Adam Dingle about 1 year ago * **Target version** deleted (<strike>_0.2_</strike>) #### #3 Updated by Jim Nelson about 1 year ago * **Target version** set to _0.3.0_ UndoManager was ripped out in a [recent commit](https://bugs.webkit.org/show_bug.cgi?id=100711). The ticket is marked for re-implementation when someone takes ownership of undo/redo. I suspect this means our strategy of relying on the undo stack to determine if the message is modified won't work against the next release of WebKit. #### #4 Updated by Eric Gregory about 1 year ago This shouldn't affect us, the commit in question seems to be removing support for the HTML5 UndoManager. We're not using that feature here -- we're only using WebKit's undo/redo API. #### #5 Updated by Jim Nelson 9 months ago * **Target version** changed from _0.3.0_ to _0.4.0_ #### #6 Updated by Jim Nelson 8 months ago * **Target version** changed from _0.4.0_ to _0.5.0_ --- Bug imported by chaz@yorba.org 2013-11-21 20:18 UTC --- This bug was previously known as _bug_ 5404 at http://redmine.yorba.org/show_bug.cgi?id=5404 Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
This is a test comment. Please ignore it. Sorry for the noise.
This may need to be addressed as part of Bug geary-wk2, since we won't have access to the undo state without IPC.
This will be fixed by the WK2 port, but it has actually become more conservative - we are now assuming the message has been modified if any mutation event has occurred. Bug 777250 to restore this once we have access to the WebKit UndoManager.
Fixed on master with commit 29b339c.