After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 713201 - Several problems using Link tool in composer
Several problems using Link tool in composer
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
master
Other All
: High normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: geary-wk2
Blocks:
 
 
Reported: 2013-05-18 05:43 UTC by Geary Maintainers
Modified: 2017-02-28 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-21 20:18:59 UTC


---- Reported by geary-maint@gnome.bugs 2013-05-18 10:43:00 -0700 ----

Original Redmine bug id: 6966
Original URL: http://redmine.yorba.org/issues/6966
Searchable id: yorba-bug-6966
Original author: John Kim
Original description:

There are a few problems with the Link tool in the composer. To begin:

  1. Copy a fully-qualifed URL into the clipboard (i.e. http://redmine.yorba.org)
  2. Open a new composer window in Geary
  3. Add some body text.

First problem:

  1. Select a word
  2. Press Ctrl+L
  3. Press Ctrl+V

The original "http://" is appended with the URL, yielding
"http://http://redmine.yorba.org" Instead, the text in the Link dialog should
be highlighted when the dialog first appears, so Ctrl+V will replace it
entirely.

Second problem:

  1. Select a word
  2. Press Ctrl+L
  3. Press Ctrl+A, Ctrl+V (to work around above problem)
  4. Click Ok

The link is inserted in the middle of that word (where you double-clicked)
using the URL as the text. The highlighted text should be linked without the
URL text being inserted anywhere.

Third (potential) issue:

  1. Select no text
  2. Press Ctrl+L
  3. Press Ctrl+A, Ctrl+V
  4. Press Ok

The URL is inserted linked. I'm unsure this is the best behavior if the cursor
is in the middle of a word, but it is how Thunderbird works, so there's
precedent.

So, this ticket is to, in the least, fix the first two problems. The third can
be discussed.

I suspect this can all be handled in a single commit. If not, we can break
this up into separate tickets.

Original description:

It's not a good title, sorry.

Steps:

1. go to a website, and Ctrl+C the whole url.

2. Ctrl+L some text in a message.

3. Ctrl+P

What should happen:

It should be the whole url. The first http:// should be replaced by the URL.

http://beerpla.net/2008/04/02/how-to-add-a-vim-file-extension-to-syntax-
highlighting/

What actually happens:

It pastes the entire string, along with http:// at first.

It looks something like this:

http://http://beerpla.net/2008/04/02/how-to-add-a-vim-file-extension-to-
syntax-highlighting/

Related issues:
related to geary - 5780: Can't add mailto: link with link button (Open)



---- Additional Comments From geary-maint@gnome.bugs 2013-07-11 15:37:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 6 months ago

  * **Subject** changed from _Linking a text and "http://" _ to _Several problems using Link tool in composer_
  * **Description** updated (diff)
  * **Category** set to _composer_
  * **Priority** changed from _Normal_ to _High_
  * **Target version** set to _0.4.0_

Good catch! When looking at this I discovered some other problems as well.
I've updated your title and description.

####

#2

Updated by Jim Nelson 4 months ago

  * **Target version** changed from _0.4.0_ to _0.5.0_



--- Bug imported by chaz@yorba.org 2013-11-21 20:19 UTC  ---

This bug was previously known as _bug_ 6966 at http://redmine.yorba.org/show_bug.cgi?id=6966

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Michael Gratton 2017-02-28 14:45:57 UTC
This was fixed on master when Bug 728002 landed.