GNOME Bugzilla – Bug 750075
Email from a specific sender not displaying right
Last modified: 2017-02-07 13:32:40 UTC
Created attachment 304206 [details] Mail example not displaying correctly All the messages I receive from that Sender display only the line "If you don't see that email correctly" or sometimes only a small portion of an image when I click "Display Pictures" Thanks for the really good work! ^-^
The problem is that the email has some silly HTML. Specifically, the body element is styled with "height: 23px". They obviously don't want a 23-pixel tall body, and they won't get it in most cases, because browsers ignore attempts to set the height of the body element. However, since we display multiple emails in the same HTML page in the conversation viewer, we have to turn that body element into a div, which does respect the height styling. This is why you get a 23-pixel tall body to the email. I note that the GMail web interface, which must do similar things, changes "height" to "min-height" on the element standing in for the body. We could also just add a "height: auto !important" rule to our CSS.
Created attachment 304276 [details] [review] Don't allow body-element surrogate to set height Forcing height: auto was easier than finding, parsing, and correcting CSS rules, so that's what this patch does.
I'm going to be setting min-height: 100% on the body in Bug 728002, so this should be fixed with that.
Well, this may have been fixed on master by 898fa33, as part of Bug 728002, but I'm not sure. There will likely be some more changes to Geary's internal HTML CSS for Bug 728002, so this will need to wait for that as well.
Fix pushed to master as commit fdde9b1.