After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 714430 - [a11y] Lack of caret browsing in the message viewer makes messages inaccessible to users who are blind
[a11y] Lack of caret browsing in the message viewer makes messages inaccessib...
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: client
unspecified
Other All
: High normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: geary-wk2 765516
Blocks:
 
 
Reported: 2012-07-14 08:31 UTC by Geary Maintainers
Modified: 2021-07-05 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch which makes the changes described in the opening report (9.38 KB, patch)
2012-07-14 20:31 UTC, Geary Maintainers
none Details | Review
Enable toggling of caret browsing for accessibility (7.23 KB, patch)
2017-02-23 02:32 UTC, Michael Gratton
none Details | Review

Description Charles Lindsay 2013-11-21 20:26:02 UTC


---- Reported by geary-maint@gnome.bugs 2012-07-14 13:31:00 -0700 ----

Original Redmine bug id: 5556
Original URL: http://redmine.yorba.org/issues/5556
Searchable id: yorba-bug-5556
Original author: Joanmarie Diggs
Original description:

The way users who are blind typically review textual content is by navigating
within it (e.g. line by line, word by word, etc.). In response their screen
reader should present the new location in speech and/or braille.

This type of navigation is also needed in order for people who cannot use a
mouse to select text for copying and pasting. Geary's lack of support for
toggling caret browsing poses a significant accessibility issue.

Proposed solution:

  1. Create a new setting and add it to preferences
  2. Associate a keyboard shortcut to toggle it (traditionally in GNOME that is F7)



---- Additional Comments From geary-maint@gnome.bugs 2012-09-26 11:48:00 -0700 ----

### History

####

#1

Updated by Adam Dingle over 1 year ago

  * **Status** changed from _Open_ to _Review_
  * **Priority** changed from _Normal_ to _High_
  * **Target version** set to _0.2_

####

#2

Updated by Jim Nelson over 1 year ago

  * **Category** set to _client_
  * **Assignee** set to _Joanmarie Diggs_

Hi Joanmarie,

The code looks fine but I'm curious if we need to add a Preferences option for
this. Looking around at other GNOME apps (Web / Epiphany, gedit) I don't see
anything in the Preferences pane for caret browsing. Would it be sufficient to
offer this via F7 alone?

####

#3

Updated by Joanmarie Diggs over 1 year ago

Jim Nelson wrote:

> Hi Joanmarie,

>

> The code looks fine but I'm curious if we need to add a Preferences option
for this. Looking around at other GNOME apps (Web / Epiphany, gedit) I don't
see anything in the Preferences pane for caret browsing. Would it be
sufficient to offer this via F7 alone?

Hey Jim. Thanks for the review!

Yes, I think it would indeed be sufficient to offer this via F7. As for what
Web / Epiphany does, it pops up "Are you sure you want to do this?" style
dialogs. (Which I have always found annoying, and why I didn't propose one in
this patch.)

####

#4

Updated by Christian Dywan over 1 year ago

Midori has F7 as well - before we had a confirmation dialog lots of users got
confused by accidentally pressing F7 without understanding what it does. So
from my experience it's crucial.

####

#5

Updated by Jim Nelson over 1 year ago

  * **Status** changed from _Review_ to _Open_

Hmm ... sounds like there's a general practice here to offer a confirmation
dialog.

Joanmarie, could you remove the Preferences option and add a confirmation
dialog? If you did that, I would have no problem landing this.

####

#6

Updated by Joanmarie Diggs over 1 year ago

Jim Nelson wrote:

> Joanmarie, could you remove the Preferences option and add a confirmation
dialog? If you did that, I would have no problem landing this.

Yup. I will be happy to. Thanks! (I meant to already have it done, but I was
traveling and now am at GUADEC with a single system and a hosed jhbuild
environment.)

####

#7

Updated by Jim Nelson over 1 year ago

Most of Yorba is at GUADEC as well, if you see us, be sure to say hi. Adam and
I are giving a keynote today at 12:30 and holding a Geary BoF/workshop on
Monday at noon. Hopefully we see you at one or both!

####

#8

Updated by Adam Dingle about 1 year ago

  * **Target version** deleted (<strike>_0.2_</strike>)



--- Bug imported by chaz@yorba.org 2013-11-21 20:26 UTC  ---

This bug was previously known as _bug_ 5556 at http://redmine.yorba.org/show_bug.cgi?id=5556
Imported an attachment (id=260982)

Unknown version " in product geary. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Michael Gratton 2017-02-23 02:32:48 UTC
Created attachment 346528 [details] [review]
Enable toggling of caret browsing for accessibility

Updated patch that removes the prefs UI and is rebased off current master.

There has a few problems caused by the GTK and WK2 ports however:

1. The conversation view won't scroll with the caret as it moves off screen
2. The overridden key handling for scrolling the conversation view up and down (Bug 772748) means it's not possible to move the cursor up and down.

(1) should be pretty easily fixable by keeping track of the cursor in the WebProcess by listening for selection changes, then sending messages back to the client as it moves, but I don't have an easy solution to (2) on hand, so I think this will have to be bumped to 0.13.
Comment 2 GNOME Infrastructure Team 2021-07-05 13:27:52 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/geary/-/issues/

Thank you for your understanding and your help.