After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 79025 - Add support for Photoshop Styles and adjustment layers
Add support for Photoshop Styles and adjustment layers
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: General
1.x
Other All
: High enhancement
: Future
Assigned To: GIMP Bugs
GIMP Bugs
: 98262 161687 166844 300523 322518 341624 349487 464727 520584 552315 619641 648053 670707 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-04-18 05:16 UTC by waiyee404
Modified: 2018-05-24 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Testcases and descriptions for PS fill and adjustment layers (CS 5, CS 6) (3.05 MB, application/zip)
2015-12-31 16:15 UTC, Max Mustermann
Details

Description waiyee404 2002-04-18 05:16:23 UTC
Please add support for Photoshop Styles, which enables a user to easily
apply styles to a layer, and also make changes to a layer without doing the
effects once again.
I don't know exactly what this belong to, maybe plugins?
Comment 1 Raphaël Quinet 2002-04-18 08:08:02 UTC
I do not know what Photoshop Styles are.  For what I read in your
description, this seems to be a bit similar to the "active layers" or
"effect layers" that have been discussed for a while on the
gimp-developer mailing list, but maybe this is something different.

It would be nice if you could add some pointers to a good description
of what these Styles are, or explain that yourself in terms that could
be understood by people who have never used Photoshop.
Comment 2 waiyee404 2002-04-18 15:16:25 UTC
Layer Styles was Layer Effects in Photoshop 5.0, then they added new
features to it and changed its name.
It allows the user to add drop shadows, inner/outer glows, bevels,
stroke, gradient/color/texture fill, etc.
It's notable that the Styles doesn't change your original image, which
means that you can safely remove the Styles from a layer.
Comment 3 iccii 2002-04-19 02:31:17 UTC
I wrote a script which simulates Photoshop's layer effects.
Style (or Effects) layer should hold effect properties so that
it can edit or change later.
http://www09.u-page.so-net.ne.jp/yd5/yositaka/files/script/layer-
effects_en.html
Comment 4 Raphaël Quinet 2002-04-19 07:09:47 UTC
Thanks for the screenshots on your page.  This is useful to understand
how this should work.  I assume that the first image with the palette
of effects/styles that you can choose from was taken from a japanese
version of Photoshop.

Anyway, this suggestion looks indeed very similar to what was
discussed several times on the gimp-developers mailing list.  Since
there is no entry yet in Bugzilla about the "effect layers" or "active
layers", I am going to leave this one open as a reminder.
Comment 5 Raphaël Quinet 2002-11-12 17:59:39 UTC
*** Bug 98262 has been marked as a duplicate of this bug. ***
Comment 6 Raphaël Quinet 2002-11-12 18:05:39 UTC
I added "...and adjustment layers" to the summary of this bug report
because it looks like both features could be implemented in a similar
way, as discussed in bug #98262.  Take a look at that report for more
details about this, including some useful links showing how these
things work in Photoshop.
Comment 7 Raphaël Quinet 2002-11-29 17:49:19 UTC
Since several bugs reports describe different but similar features
related to "groups of layers", here is a list for quick reference:
- "linked" layers: bug #51112, bug #86277, bug #86337.
- "active" layers: bug #79025, bug #98262 (dup).
Comment 8 Alan Horkan 2003-07-23 18:38:35 UTC
Changes at the request of Dave Neary on the developer mailing list.  
I am changing many of the bugzilla reports that have not specified a target
milestone to Future milestone.  Hope that is acceptable.  
Comment 9 Jakub Steiner 2003-07-24 09:09:44 UTC
marking Milestone:Future
Comment 10 agnlh 2004-08-15 11:25:28 UTC
Is the status of this feature in 1.x or 2.x what? Gimp isn't an option until the
functionality is in, it's just too laborious building more complex images
without havign dynamic layers. :(
Comment 11 Ricard Marxer Piñón 2004-12-17 10:44:35 UTC
I think this feature is very important, but it is a big update.  Because it must
be well thought so it can be extensible to new future ways of image manipulation.

An idea of it would be to have an extra environement which works as workflows
(with sources, transformations, mixers and sinks) the idea is that
"adjustment"," active" or "effect" layers could be seen as transformations in
the environement, and normal layers could be seen as sources or sinks.  You
could also demix a normal layer in different channel layers using the
mixers/demixers.

I know it's a bit vague as idea, many others might have thought of it and it
might not be the rigth place.  But I'm new and don't know where else to say this.

A commercial (arrghh) program that works in a similar way and could give you a
good idea of what I mean (althought it is video not image) it is visualJockey.
http://www.visualjockey.com/software/software_description.page.php?commercial_id=1

gracias,
ricard
Comment 12 Sven Neumann 2004-12-17 11:26:11 UTC
Thanks for your comments but we already have a rather good idea of how this
should be implemented. And yes, it involves having a graph of operations. This
is codenamed GEGL ;)
Comment 13 Ricard Marxer Piñón 2004-12-17 12:30:29 UTC
Thanks for the reference sven.  I have a little bit of experience in image
treatement and programming.  I'm going to look for this codename and see if I
can participate.  I must congratulate you for your work on GIMP, it's very
impressive, and very well organized.
see you in GEGL!
Comment 14 Gezim Hoxha 2004-12-19 12:59:17 UTC
*** Bug 161687 has been marked as a duplicate of this bug. ***
Comment 15 weskaggs 2005-02-09 20:59:58 UTC
*** Bug 166844 has been marked as a duplicate of this bug. ***
Comment 16 furryball 2005-04-13 23:08:38 UTC
Are there any ETAs? Waiting for the GEGL? A few dozen years or so? It would be  
nice to see Gimp to move to the league of real image editing applications. 
Comment 17 Sven Neumann 2005-04-13 23:16:11 UTC
GIMP is a volunteer-driven project. Basically a handful of people working on it
in their free time. At the moment nobody is working on GEGL so it is impossible
to say anything about an ETA. As long as noone's working on GEGL and the GIMP
developers are busy doing other things, this will take an infinite amount of
time. If on the other hand, a talenteered hacker shows up who has a need for
these features and some free time to put into this, this could happen rather soon.
Comment 18 Sven Neumann 2005-04-13 23:18:48 UTC
It am doing Pippin wrong if I say that nobody is working on this. There's a very
nice prototype of a gegl-like infrastructure being developed and even used. See
http://pippin.gimp.org/gggl/.
Comment 19 Manish Singh 2005-04-13 23:22:53 UTC
Also, whining and begging for an ETA without offering anything constructive is
rather rude behavior.
Comment 20 Michael Schumacher 2005-04-14 08:12:14 UTC
The lack of motivating examples is probably something that keeps contributors
from contributing. A good idea would be to pick bug reports that can be solved
by GEGL and show how they can be solved.

This could even be done by someone who doesn't know anything about GEGL except
the things that are mentioned on its website or the mailing lists - writing a
book about something you don't understand is the best way to grasp it :)
Comment 21 Michael Schumacher 2005-05-09 17:24:55 UTC
*** Bug 300523 has been marked as a duplicate of this bug. ***
Comment 22 Michael Schumacher 2005-05-09 17:25:38 UTC
Bug 300523 contains a PSD file with some layer effects.
Comment 23 Matteo Azzali 2005-08-27 21:19:10 UTC
Styles are a fast way to generate 2,5D (opposed to real 3D) renders in layers
or selections. Using vectors or bezier you can "profile" a "border" to make a 
render. Using styles renders much faster the making of effects or FX text.
You can find more watching some tutorial:
http://www.photoshopcafe.com/tutorials/super%20tutorial%202/website%203.htm
http://www.graphic-design.com/Photoshop/cutout/
Comment 24 Matteo Azzali 2005-08-28 02:41:55 UTC
Ok, here is some in-depth analisys of how styles are rendered.(contour fx, but
most of the
other fx are similar o much easier).

First you have a layer, and can figure styles as extended attributes for that layer.
Then you have rgb raster graphics for that layer, but you don't care (any color
is the same)
At least you have a mask.Think of it as an alpha channel from 0(layer is
transparent) to
255 (layer is 100% opaque). You can extract a vector path from the border zone (when
you alpha channels move from 0 to 1 , no fuzziness).

Ok, now you have a path (or more than one, depending on the mask). Most of
conceptual
work is done, now is more math.Think to your path as an inkskape shape, and think to
set a contour inner-only (you will not influence the area in which you alpha
channel is
0) of variable depth.
You can extract a tangent value (in 2D)for every knob, thus you can also get an
"inward
normal" for it, long as your contour is large.

Goin to 3D....
Now you need to give a profile to that contour , using 1 or more straight/bezier
lines
(think to a bi-dimensional graph,where left border is your knob, right border is the
top of your "inward normal", height is.... height). 
Using math you can interpolate values for normals (in 3D now)all around the contour.
then you have an angle on the 2D plane and one vertical angle for the light, thus
you can get the difference with the angle of the normal -a value from 0
(parallel) to 
90 degree (perpendicular). Now you have a "light intensity map" for all your
contour.
Playing with this intensity you can get a variety of effects, (other than very 
pixel-precision bump mapping), playin with glossiness for example (converting
the "light intensity map" so the max is at 75 degree, every value over 75 is
saturated
to be pure white.

Hoping this can help.....
Comment 25 Michael Schumacher 2005-11-26 23:27:41 UTC
*** Bug 322518 has been marked as a duplicate of this bug. ***
Comment 26 Leon Brooks 2005-11-28 00:37:26 UTC
If you need a co-ordinator/whip for GEGL, I foolishly volunteer. My 
understanding of computer graphics algorithms is quite shallow, but it looks 
like what you really need is just a warm body to take responsibility and move 
things along, no? 
Comment 27 Michael Schumacher 2005-11-28 10:34:54 UTC
The current state is summarized in http://carol.gimp.org/blog/gimp/gegl/
Comment 28 gagarine 2006-05-13 10:52:07 UTC
[citation anlar]
Is the status of this feature in 1.x or 2.x what? Gimp isn't an option until the
functionality is in, it's just too laborious building more complex images
without havign dynamic layers. :(
[/citation]
Yes... on more vote for adjustment layer... until that I'm (and lot of photographe) sadly on topshop :(
Comment 29 Michael Natterer 2006-05-13 13:03:09 UTC
*** Bug 341624 has been marked as a duplicate of this bug. ***
Comment 30 David Gonzalez 2006-05-19 06:28:27 UTC
I'm not quite sure what photoshop styles are 

anyway about the adjustment layers, correct me if i'm wrong, but is the the little "manage box" that pop up when you right-click and edit the layer to add gradients etc etc? 
Comment 31 Michael Natterer 2006-05-19 08:24:30 UTC
What are you talking about? The "manage box" to "add gradients etc"?
Comment 32 gagarine 2006-05-19 10:14:18 UTC
A little explication of adjustement layers:
http://www.bairarteditions.com/pages/tutorials/photoshop/layadjust.html
You can naturally make a mask on an adjustement layer just like any other layer.

And a little explication of a style "layer":
http://iit.bloomu.edu/vthc/Photoshop/specialeffects/layerstyles.htm

Syle is not an independent layer but is applied to a layer like an "effect".
Comment 33 Michael Natterer 2006-05-19 12:14:33 UTC
I know what adjustment layers and layer styles are. I'm just confused
about the stuff said in comment #30. It's probably stuff from the
photoshop interface. Please keep in mind that most developers don't
have photosop, or not even an operating system to run it.
Comment 34 David Gonzalez 2006-05-19 15:36:56 UTC
which was why i said "correct me if i'm wrong" but gagarine answered my question, what I meant was this http://iit.bloomu.edu/vthc/Photoshop/specialeffects/IMAGES/LayerStyleDialog.gif 

but it looks like i confused it sorry
Comment 35 Christian Malcoms 2006-08-03 12:40:16 UTC
The link http://carol.gimp.org/blog/gimp/gegl/ seems to be dead.
How are things going? I just can't wait till this feature will be ready (wich will finally free me from PS :) )
Comment 36 Michael Schumacher 2006-08-03 12:45:12 UTC
http://codecave.org/?weblog_id=gegl-xml might be interesting
Comment 37 gagarine 2006-08-03 15:59:34 UTC
Ho yes it's very interesting...
[citation]
I just can't wait till this feature will be ready (wich
will finally free me from PS :)
[/citation]
me to...
Comment 38 Sven Neumann 2006-08-07 11:51:42 UTC
*** Bug 349487 has been marked as a duplicate of this bug. ***
Comment 39 Teddy Widhi Laksono 2006-11-30 02:54:58 UTC
Yes i also waiting the feature of adjustment layer in GIMP. becoz i difficult to remove for example i wanna remove only level/curve adjustment in my picture. but i can't do that. its look all adjustment we create (level/curve/hue saturation/brigtnes contrast/ and other) embed in the layer we are selected. it should have some fake layer for example. so we can remove only some fake layer (adjustment layer).

thank you and sorry my english.
Comment 40 Manfred Joerg 2007-01-13 21:53:01 UTC
I implemented an adjustment layer for the colourise tool based on version 2.2.13. It should be no problem to implement adjustment layers for any other colour tools. However my current implementation is far from being perfect.
Comment 41 Sven Neumann 2007-01-13 22:11:27 UTC
As soon as 2.4 is out, we will port all image-map tools to GEGL. That is also the route we are going to take towards adjustment layers.
Comment 42 gagarine 2007-01-15 12:35:07 UTC
Thanks from the bottom on my heart....
Comment 43 Sven Neumann 2007-08-08 16:35:33 UTC
*** Bug 464727 has been marked as a duplicate of this bug. ***
Comment 44 iyeru42 2007-08-08 16:55:43 UTC
I think I'd like the blending options stuff too.
Comment 45 gagarine 2007-08-08 20:09:04 UTC
Krita (http://en.wikipedia.org/wiki/Krita) have a system of adjustment layers: http://docs.kde.org/development/en/koffice/krita/layers-adjustment.html

(if you don't know this feature but you can't install photoshop)
Comment 46 iyeru42 2007-08-08 22:25:47 UTC
(In reply to comment #45)
> Krita (http://en.wikipedia.org/wiki/Krita) have a system of adjustment layers:
> http://docs.kde.org/development/en/koffice/krita/layers-adjustment.html
> 
> (if you don't know this feature but you can't install photoshop)
> 

But that's for KDE, right? We're talking more or less GNOME/Windows. Or are you just giving an example so the GIMP People can copy off of it?
Comment 47 Raphaël Quinet 2007-08-09 09:27:27 UTC
Please do not use this bug tracker for random discussions.  Use the mailing lists for that (http://www.gimp.org/mail_lists.html).

This bug report is rather old as you can see from the dates of the first comments. In the meantime, most GIMP developers became aware of what Styles and Adjustment Layers are, and how they can be useful. This bug is still open because nobody had time to work on these new features yet. Volunteers are still welcome. But again, please do not use this bug tracker for stating that you need this feature or that you would like developers to prioritize it. Such discussion belongs to the mailing lists. Let's keep the bug reports focused on technical issues.
Comment 48 Jowan 2008-01-01 22:05:43 UTC
I would like to vote for this feature
Comment 49 Sven Neumann 2008-03-05 20:52:26 UTC
*** Bug 520584 has been marked as a duplicate of this bug. ***
Comment 50 iyeru42 2008-07-04 19:09:35 UTC
(In reply to comment #47)
> Please do not use this bug tracker for random discussions.  Use the mailing
> lists for that (http://www.gimp.org/mail_lists.html).
> 
> This bug report is rather old as you can see from the dates of the first
> comments. In the meantime, most GIMP developers became aware of what Styles and
> Adjustment Layers are, and how they can be useful. This bug is still open
> because nobody had time to work on these new features yet. Volunteers are still
> welcome. But again, please do not use this bug tracker for stating that you
> need this feature or that you would like developers to prioritize it. Such
> discussion belongs to the mailing lists. Let's keep the bug reports focused on
> technical issues.
> 

How do I join one?
Comment 51 tobias 2008-07-31 08:45:41 UTC
Go to http://www.gimp.org/mail_lists.html click on the list name you like to join and subscribe to the list by entering your email address and a password. 
Comment 52 Martin Nordholts 2008-09-15 17:18:03 UTC
*** Bug 552315 has been marked as a duplicate of this bug. ***
Comment 53 Martin Nordholts 2011-03-14 07:37:53 UTC
Currently aiming for 3.2, putting on Future for now
Comment 54 trusktr 2011-03-14 08:34:05 UTC
Hey Martin, when's Gimp 3 coming out?
Comment 55 Michael Natterer 2011-04-09 21:14:29 UTC
*** Bug 619641 has been marked as a duplicate of this bug. ***
Comment 56 Martin Nordholts 2011-04-19 04:40:43 UTC
*** Bug 648053 has been marked as a duplicate of this bug. ***
Comment 57 Michael Natterer 2012-02-27 20:54:38 UTC
*** Bug 670707 has been marked as a duplicate of this bug. ***
Comment 58 Max Mustermann 2015-12-31 16:15:10 UTC
Created attachment 318079 [details]
Testcases and descriptions for PS fill and adjustment layers (CS 5, CS 6)

Here are two testcases with fill and adjustment layers, created with PS CS 5 and CS 6. See the description files for more details.
Comment 59 GNOME Infrastructure Team 2018-05-24 10:44:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/26.