GNOME Bugzilla – Bug 100600
Notification area doesn't support all the panel background types
Last modified: 2015-03-24 13:00:56 UTC
The tray applet should have a transparent background. It seems to be set strictly to the default grey, so now that I have colorized my panel, it doesn't blend in, it appears as a large grey box on the colorized panel.
Re-assigning to gnome-panel-maint. Apologies for the spam.
*** Bug 162040 has been marked as a duplicate of this bug. ***
*** Bug 162047 has been marked as a duplicate of this bug. ***
Looks like this is not doable currently... As explained by this email from Davyd : http://mail.gnome.org/archives/desktop-devel-list/2005-February/msg00313.html The notification area just gives some space to applications to draw their own icons. These icons draw their own backgrounds, and there's no way for them to know the current desktop background. The panel knows the background, but it can only pass it to actual applets... So it's not solvable right now :-(
*** Bug 172933 has been marked as a duplicate of this bug. ***
Marking this to get looked at, since there might be some code in bug 150726
*** Bug 309066 has been marked as a duplicate of this bug. ***
Davyd: please use the gnome milestone field only for things that would block the whole release. Thanks, duder...
*** Bug 317735 has been marked as a duplicate of this bug. ***
*** Bug 164713 has been marked as a duplicate of this bug. ***
*** Bug 318302 has been marked as a duplicate of this bug. ***
So this is impossible to fix with the current implementation? Is it possible to change the implementation then? :) This is on top of the list of things making the gnome-panel "not pretty", with non-transparent panel handles coming on second place. Sorry for the bugspam, but it would really be nice to see this one fixed.
David: it's not an implementation issue, as I understand it. It's a spec issue.
See also https://bugzilla.novell.com/show_bug.cgi?id=135448 for the corresponding bug in Novell. KDE does implement transparency for their systray icons; we should be able to do pretty much the same thing.
Fuck, what a mess of bugs. Patches for the EggTrayIcon problem: bug #150726, bug #306974. Has anyone tested them at all?
I understand that KDE implemented an extension to the spec laid out by Ryan Lortie, where you passed a pixmap of background data to the notification icon in an XAtom (exact terminology subject to correction). His bug is bug #306974.
This is not true. I had a talk with Aaron Seigo earlier today and he did not implement the spec.
Ok. How did they implement it in the end?
They didn't. He has different ideas for KDE4 that are closer to using actual alpha transparency.
Ok. Evidently I misunderstood comment #14. It would be nice to do all of our transparency with real compositing if it is available.
*** Bug 326687 has been marked as a duplicate of this bug. ***
Mass changing: milestone 2.12.x => milestone 2.14.x
*** Bug 330143 has been marked as a duplicate of this bug. ***
*** Bug 332032 has been marked as a duplicate of this bug. ***
*** Bug 331930 has been marked as a duplicate of this bug. ***
*** Bug 332619 has been marked as a duplicate of this bug. ***
Created attachment 60589 [details] [review] initial transparency support this patch is based on Dan patch for eggtrayicon.c. It allows transparency to be set correctly initially. But expose event are not handled nor style changes.
Created attachment 60606 [details] [review] slightly better version Oops, I really wasn't planning to work on this when I made that comment on bug 150726, but then I realized it wasn't much work. :) Fortunately that means not much duplicated effort too. Here's my version of the patch, which is mostly the same, but also forces the icons to redraw themselves at the right times.
Created attachment 60607 [details] droolage
patch works fine, except for background update : try changing transparency for panel background.
Hm... I'm testing against gnome-panel 2.12, and the background updates fine. If you're testing against HEAD, I know the background code has changed some there. You just need to hide+show the contents of the tray any time the panel signals the tray that its background has changed.
Created attachment 60777 [details] [review] version working for HEAD Improved version, based on Dan comment. It works fine with CVS HEAD !!
Created attachment 60779 [details] [review] better version without my top secret debug code ;)
ok that .png rocks. now what? is this going to be implemented?
Created attachment 61408 [details] Panel Properties
*** Bug 337627 has been marked as a duplicate of this bug. ***
Is this patch going to make it into 2.14.2? I really can't understand why something so small (~100 lines) and makes gnome-panel look sooo much better isn't already in CVS head. The bug this patch fixes is my last big complaint with gnome-panel.
I've applied the patch to the Ubuntu package of 2.14.1 and it makes no difference for the notification area icons, they are still used a solid color
Right, because EggTrayIcon also needs to be patched, in each package that uses it (bug 150726).
FWIW. GtkStatusIcon now has the equivalent patch to bug 150726
I committed an enhanced version of the patch. I didn't connect to the expose event since it works without it and I don't think it's needed. Same for double buffering. Also, the icons flicker when a new icon is added. I opened bug 350820 about this.
The expose event handler is definitely only needed if you turn off double buffering. I forget what the non-double-buffering was for, but it was needed in some case. Did you test with a variety of gtk themes? It might only be needed for themes that do certain kinds of drawing.
Dan: I tested with the themes I had, but it might not be enough, indeed. Do you remember for which theme it was needed?