GNOME Bugzilla – Bug 83552
mouse clicking in the list view shouldn't initiate rename
Last modified: 2004-12-22 21:47:04 UTC
double right clicking in the list view shouldn't initiate rename. reasons: 1. It is too easy to accidentally initiate a rename when simply trying to open or launch an item. (This happens here and there for me still) 2. Renaming is a somewhat dangerous operation. We shouldn't make it too easy, especially with the lack of an undo feature. 3. Creates a behavioral difference between single and double click modes. Obviously in single click mode this feature will never work. 4. Is inconsistent with the behavior of the icon view. We have a rename option in the context menu. Making the user explicitly choose to rename is a much better ui, and prevents them from accidently renaming files.
I mean left clicking, but this should apply to all clicks...
*** Bug 82575 has been marked as a duplicate of this bug. ***
Created attachment 9618 [details] [review] Proposed patch
andrew did you email this patch to the nautilus list???
*** Bug 88650 has been marked as a duplicate of this bug. ***
Usability, anyone disagree with this???
Fine by me, especially if the F2 shortcut now works properly for desktop icons as well.
*** Bug 89214 has been marked as a duplicate of this bug. ***
Created attachment 10497 [details] [review] here is a more up to date patch that does the same thing, just against nautilus-2.0.4
after further review of the patch, this also seems to disable the F2 function that makes a filename editable. After applying the patch and building, double clicking on a file in list view does not make the filename editable, nor does pressing F2.
The above patch is NOT the correct fix. Applying this patch disables the "F2" and Right Click->Rename functionality. The appropriate fix is to remove code that causes a double click to initiate and editable cell.
*** Bug 92019 has been marked as a duplicate of this bug. ***
Whether or not you should be able to rename the file by single clicking is one thing, but the current behaviour when renaming is activated when you double-click on a filename in the list view is a real show-stopper.
*** Bug 99988 has been marked as a duplicate of this bug. ***
*** Bug 100562 has been marked as a duplicate of this bug. ***
Created attachment 13492 [details] [review] patch that fixes this bug but maintains hotkey and rename-from-context-menu functionality
This problem is totally crippling the tree view in double click mode: * double clicking an already selected item renames instead of running it * double clicking an unselected item after bug 91176 is fixed causes the file to be opened and then renamed. As well as all the reasons above as to why it shouldn't be there in the first place. This really needs to go in for 2.2. Setting TARGET2.2.0 and GNOMEVER2.1 keywords.
I tested the patch for 91176 together with my patch for this bug. With the patches, the problems Mark describes in the previous comment are both fixed.
I can confirm that these two patches applied together *unbreak* the list view in double click mode. I'm upping the priority of this bug because it has a patch and because rename is causing so much breakage and usibility woes.
After reading this and the discussions in nautilis-list, could we say that consensus is that the current implementation has problems and better be disabled for GNOME 2.2? This is not to say that renaming by single-clicking should be gone forever, but it's easier to disable it for now and look at other ways of implementating it after 2.2. For example, *double-clicking* should never initiate a rename, which happens with the current code if the item is selected. So, who applies the patch? Alex?
Created attachment 13654 [details] [review] Updated patch against current cvs.
I updated my patch to apply to the current CVS. I also made a small change to make the code look better (thanks, Dave).
I applied this patch, thanks.
Could changing this have caused bug 104334?