After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638943 - Remove gapless setting (keep it always on)
Remove gapless setting (keep it always on)
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal enhancement
: 3.0
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
: 638942 (view as bug list)
Depends on: 612929 613041 617620 617957 619970 621222 627391 629541 634798 636992 639000 642458 648498 654004 673342 674293 694176 732745
Blocks:
 
 
Reported: 2011-01-07 21:42 UTC by David Nielsen
Modified: 2020-03-17 08:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Nielsen 2011-01-07 21:42:58 UTC
Looking at our bug reports most of our users are enabling gapless.
Perhaps we should consider enabling it by default.

Pros:

Users are using it and consider it vital functionality.

Cons:

It seems to cause problems for playback in certain cases. Also the unit tests were likely written before gapless arrived or do not consider any impact it has. The code looks to have a lot of workarounds in place which could prove problematic.
Comment 1 David Nielsen 2011-01-07 21:46:31 UTC
*** Bug 638942 has been marked as a duplicate of this bug. ***
Comment 2 Michael Martin-Smucker 2011-01-07 21:56:59 UTC
I thought gapless was already on by default, and unless some of the bigger "depends on" bugs are fixed before 2.0, I really think it should be off by default for that release.  Another one to add to the list is Bug 619970 (and the possible duplicate: Bug 621222). Gapless has a tendency to double not only scrobbles, but play counts in the library as well, which can cause problems with the Unheard smart playlist.
Comment 3 David Nielsen 2011-01-07 22:11:56 UTC
Actually it appears to be, I must have tested with an old gconf profile in place.

http://git.gnome.org/browse/banshee/tree/src/Backends/Banshee.GStreamer/Banshee.GStreamer/PlayerEngine.cs#n859

But then let's track this to see if we should flip this off for 2.0 unless we can fix the issues with it.
Comment 4 Gabriel Burt 2011-05-02 19:54:58 UTC
For 2.1/2.2 I'd like to remove this option, and have it always enabled.  We now require recent enough gst to make this happen.  I also want to nuke libbanshee, so we'll need to reimplement/test the gapless playback in the gst# backend.
Comment 5 Andrés G. Aragoneses (IRC: knocte) 2014-01-28 13:22:50 UTC
(In reply to comment #4)
> For 2.1/2.2 I'd like to remove this option, and have it always enabled.  We now
> require recent enough gst to make this happen.

Renaming summary to map to this endeavor instead (happening real soon now).
Comment 6 André Klapper 2020-03-17 08:49:07 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.