After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617620 - [gapless] Last track scrobbled twice
[gapless] Last track scrobbled twice
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Last.fm
git master
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
: 636308 640860 687593 (view as bug list)
Depends on:
Blocks: 638943
 
 
Reported: 2010-05-04 08:57 UTC by Hernando Torque
Modified: 2020-03-17 08:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
parts of --debug (6.90 KB, text/plain)
2010-05-05 00:35 UTC, Hernando Torque
Details
Some tests made in gapless mode (11.26 KB, text/html)
2014-02-09 11:16 UTC, Ismael Olea
Details

Description Hernando Torque 2010-05-04 08:57:22 UTC
When playing an album, the last track is scrobbled twice.

To reproduce:

* Choose an album
* Play the whole last track
* Wait a bit - song should be scrobbled twice (first with "x minutes ago", the second with "Just listened")

Not yet tried with custom playlists.

Using Ubuntu's daily PPA, version 1.6.0+git20100430.r1.98b1dea-0ubuntu1+lucid
Comment 1 Hernando Torque 2010-05-04 16:10:14 UTC
Results of a git bisect session:

dd6c1c3a4380e34c2467e4a8f835371e337477ff [TrackActions] Reserve a string for bgo#611923 -> good

40c1006a41bfa920b0d3c534b9f1d6e230ff7866 Merge branch 'gapless-ng' -> fails to build (no gnome-sharp-2.0)

df173cceb43ed1e54055f559364c0a9fc991aadc [build] Build YouTube extension by default -> bad

The second commit seems more promising I guess.
Comment 2 Alexander Kojevnikov 2010-05-04 23:22:10 UTC
Do you have gapless playback switched on in preferences?
Comment 3 Hernando Torque 2010-05-05 00:35:25 UTC
Created attachment 160312 [details]
parts of --debug

Yes, and surprise: after turning it off the track only gets scrobbled once.

I'm attaching parts of --debug output for 

1.) start with gapless turned off, playing a last track
2.) turn gapless on, playing a last track
3.) with gapless on, playing a track in the middle

Although there are "Audioscrobbler upload failed" messages in 1.) and 3.) those tracks got reported.
Comment 4 Hernando Torque 2010-07-06 09:36:39 UTC
Another observation:

Playing track 'A' over 50 % (so last.fm will pick it up) and then skipping to 'B' will report 'B' instead of 'A' (last.fm showing 'B' finished and 'B' playing).

This might be a different bug, but it also stops with deactivating gapless playback.
Comment 5 dror3go 2010-09-28 23:59:42 UTC
Also - this causes the play-count to display a wrong number, at it increases the count twice. Exact result as in submitting to last.fm, so I guess it's the same bug.

Another issue I suspect is the same: play-count increases for no reason when double clicking on a song. Right when double-clicking it - the count increases. clicking on the play button in the toolbar or hitting the play button on my keyboard doesn't cause this bug, only double click.
Comment 6 kfverweij 2010-11-29 23:44:25 UTC
This happens to me too with gapless play enabled. I also have Hernando's bug which seems to be related to gapless playback as well.
Comment 7 kfverweij 2010-11-29 23:45:05 UTC
I meant Hernando's bug as he describes in Comment 4.
Comment 8 Michael Martin-Smucker 2010-12-02 17:21:22 UTC
*** Bug 636308 has been marked as a duplicate of this bug. ***
Comment 9 John Halton 2010-12-03 14:37:24 UTC
I'm also encountering this bug, and had reported it on Launchpad (https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/684207). 

Turning off gapless playback stopped the duplicate tracks appearing. It also meant that my last.fm profile page now shows the currently-playing track (with the "listening now" animated icon next to it), which wasn't happening previously.
Comment 10 Michael Martin-Smucker 2011-01-28 22:12:27 UTC
*** Bug 640860 has been marked as a duplicate of this bug. ***
Comment 11 crwinters 2012-11-29 02:23:52 UTC
*** Bug 687593 has been marked as a duplicate of this bug. ***
Comment 12 Ismael Olea 2014-02-04 20:22:28 UTC
This is happening still in the last stable-2.6 branch: https://bugzilla.gnome.org/show_bug.cgi?id=679938#c11
Comment 13 Ismael Olea 2014-02-09 11:16:41 UTC
Created attachment 268562 [details]
Some tests made in gapless mode

Note that the behaviour with wma is equivalent with ogg and different from mp3 (an wav).
Comment 14 Andrés G. Aragoneses (IRC: knocte) 2014-02-09 11:33:19 UTC
Thanks for the testing, but let's not make things more complicated than they are. That is:

- What is the column 'unheard mode'?
- Does the column "unheard" represent the "Unheard" smart playlist? If yes, I would recommend deleting this from the table as it seems irrelevant to this bug (as the bug also happens when smart playlists are not used).

If, after we fix this bug, you notice a new bug about smart playlists, please open a new bug. (Otherwise making things more complicated than they are will just delay or deter developers from finding a bugfix.)

Thanks
Comment 15 André Klapper 2020-03-17 08:50:32 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.