After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648498 - [gapless] Ubuntu sound menu doesn't update songs if played from Play Queue
[gapless] Ubuntu sound menu doesn't update songs if played from Play Queue
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Other Extensions
2.0.0
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 648576 648586 651631 652271 (view as bug list)
Depends on:
Blocks: 638943
 
 
Reported: 2011-04-23 05:26 UTC by Jørgen Fiskum
Modified: 2011-08-19 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GStreamer.PlayerEngine: Fixed soundmenu song metadata update (1.23 KB, patch)
2011-06-10 10:45 UTC, Dinh Ngoc Tu
rejected Details | Review

Description Jørgen Fiskum 2011-04-23 05:26:49 UTC
Component: Sound Menu Integration extension

OS: Ubuntu 11.04 (Natty)

Summary: 
When i play songs from a automated Play Queue filling in songs from a playlist, the Ubuntu Sound Menu is a song behind when displaying songs. The notification notifying about the song change shows the right song, but the Sound Menu shows the song that just finished playing (seems to be one song behind the current playing). Just happens when I play from the Play Queue, and only if I don't change the song manually (ie. playing from a playlist or just playing a song from the Music library produces the correct behavior).

Steps to Reproduce:
 - Play songs from the Play Queue
 - Let a song be played and let the player change to the next song automatically
 - Looking in the Sound Menu in Ubuntu it now shows the last played song and not the current playing

Expected Results:
 - When looking at the Sound Menu it should always show the current playing song

Build:
Banshee 2.0 (2.0.0)
Comment 1 Rafael Gomes 2011-04-23 16:06:47 UTC
Thanks for taking the time to report this bug.
However, this application does not track its bugs in the GNOME bugzilla. We kindly ask you to report the bug to the application authors. For a selective list of other bug tracking systems please consult http://live.gnome.org/Bugsquad/TriageGuide/NonGnome.

If the affected third party application has a bug tracking system you should investigate whether a bug for the reported issue is already filed in this system. If it has not been filed yet please do so. Also ensure that both bug reports contain a link to each other.

You can try https://bugs.launchpad.net/ubuntu

Thanks in advance!
Comment 2 Jørgen Fiskum 2011-04-23 21:44:43 UTC
(In reply to comment #1)
> Thanks for taking the time to report this bug.
> However, this application does not track its bugs in the GNOME bugzilla. We
> kindly ask you to report the bug to the application authors. For a selective
> list of other bug tracking systems please consult
> http://live.gnome.org/Bugsquad/TriageGuide/NonGnome.
> 
> If the affected third party application has a bug tracking system you should
> investigate whether a bug for the reported issue is already filed in this
> system. If it has not been filed yet please do so. Also ensure that both bug
> reports contain a link to each other.
> 
> You can try https://bugs.launchpad.net/ubuntu
> 
> Thanks in advance!

I think you misunderstand my report, this is not a Ubuntu Sound Menu problem, but a problem with Banshee sending wrong information to the Sound Menu. And Bansheed only do this when I am playing from the Play Queue in Banshee. So there seems to be a problem with Banshee sending information from the extension Play Queue to the extension Sound Menu Integration. And this is the Banshee bug list isn't it? I am not reporting a problem about Ubuntu, but about a problem with two core extension in Banshee (as of Banshee 2.0.0 the Ubuntu Sound Menu extension was incorporated as a core extension for Banshee).
Comment 3 Michael Martin-Smucker 2011-04-25 16:49:31 UTC
*** Bug 648576 has been marked as a duplicate of this bug. ***
Comment 4 Michael Martin-Smucker 2011-04-25 16:51:18 UTC
*** Bug 648586 has been marked as a duplicate of this bug. ***
Comment 5 Michael Martin-Smucker 2011-04-25 16:55:13 UTC
Marc mentioned in Bug 648586 that 'gapless playback' was turned on in Edit > Preferences.  Is anyone able to reproduce this problem with gapless playback turned off?  There are some known issues related to the gapless feature and track changes, so I wouldn't be surprised if it's at least partially responsible for this.
Comment 6 Marc Hines 2011-04-25 17:24:58 UTC
I will retry this tonight (when I get home) with gapless playback off.
Comment 7 Marc Hines 2011-04-26 03:29:46 UTC
With 'gapless playback' turned off, the incorrect behavior stops.  So this is indeed part of the 'gapless playback' set of issues.

My I suggest hiding the 'gapless playback' option until the issue it causes can be dealt with?  Playback is excellent either way, so hiding it does not seem a loss to **this** end user.

Thanks for you hard work!  Marc...
Comment 8 Jørgen Fiskum 2011-04-26 08:04:57 UTC
I am also getting the correct behavior with 'gapless playback' turned off. 

If this is something that could be discovered in a log I would be happy to produce that if someone tells me how to proceed doing so. If it is a more intricate problem, I'm afraid I'm not to much help, as my coding abilities are almost non-existent.
Comment 9 Michael Martin-Smucker 2011-04-26 14:13:54 UTC
Thanks to all of you who reported this and helped track it down to gapless playback. With Ubuntu's final release only a couple days away, it's probably a bit late to break the feature freeze and disable gapless playback out of the box, but I opened a ticket downstream just in case: https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/771249

I doubt anything relevant will show up in a log, but if you want, you can obtain a debug log by following the directions here: http://live.gnome.org/Banshee/CommonQuestions/Logs
Comment 10 Michael Martin-Smucker 2011-06-01 12:51:42 UTC
*** Bug 651631 has been marked as a duplicate of this bug. ***
Comment 11 Dinh Ngoc Tu 2011-06-10 10:44:59 UTC
*** Bug 652271 has been marked as a duplicate of this bug. ***
Comment 12 Dinh Ngoc Tu 2011-06-10 10:45:57 UTC
Created attachment 189610 [details] [review]
GStreamer.PlayerEngine: Fixed soundmenu song metadata update

OnNextTrackStarting() already called OnEventChanged(StartOfStream),
but MPRIS won't update the metadata unless you explicitly force it to do so.
This patch fixes that problem by calling OnEventChanged(TrackInfoChanged).
Comment 13 Andrés G. Aragoneses (IRC: knocte) 2011-06-10 10:55:55 UTC
One liner patch, good candidate to make it to the stable branch too, thanks devper!
Comment 14 Bertrand Lorentz 2011-08-19 13:40:23 UTC
Comment on attachment 189610 [details] [review]
GStreamer.PlayerEngine: Fixed soundmenu song metadata update

Thanks for the patch !

The MPRIS extension does the same things for the StartOfStream and TrackInfoUpdated events, so that change would only work around the real issue.
I've committed what I think is a better fix :

http://git.gnome.org/browse/banshee/commit/?id=360d92f

See the commit message for some explanations.
Comment 15 Bertrand Lorentz 2011-08-19 13:40:39 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.