GNOME Bugzilla – Bug 260354
Window List Needs To Reflect New Messages
Last modified: 2013-09-10 14:04:26 UTC
We added a larger number of test users in Evo 1.5.9 and I'm hearing from a lot of people that they in the old version that they used the fact that the title bar changes to display new email "Inbox (2) - Ximian Evolution" in their task list on the panel to watch for new messages. This allowed them to be in other workplaces and still be able to monitor their email. It's been requested that the title bar have the same functionality in this version, and display new message counts.
this sounds suspiciously like a duplicate of a shell bug that was punted. this is quite a lot of work to fix because the shell no longer knows anything about the current view, and there are no interfaces to provide it that information.
Obviously, you know the code better than anyone. But in the place where the folders are updated with correct unread message counts, couldn't those be moved into a string that is then placed in the title bar? I know this seems like a minor issue, but my sample of testers indicated this is used very often by "users". I want them to feel that 2.0 is an 'upgrade'. Thanks for consideration.
well that comment was more for us about the bug, yeah i definitely agree it would be nice. the problem is that status area is a widget controlled and managed entirely by the component, the shell has no knowledge about it at all. its just a black box as far as it knows. so there's no way to pass status/context info back to the shell. there's no way to even identify windows or views or anything for the running shell instance outside of the shell, it is a mess. i'll have a quick look at extending some of the idl's for the necessary interfaces, but its probably at least a days work to complete.
blah so i half implemented it 'cause i have nothing better to do on a friday night. i'll see what the other guys think as this affects all of evo. (and i'll nick it off jeff)
Created attachment 43898 [details] [review] whee
Created attachment 43902 [details] [review] changes for evo
Created attachment 43903 [details] [review] changes for exchange connector
it'll have to wait, jp doesn't like this and i'm not wasting more time on it.
*** bug 255410 has been marked as a duplicate of this bug. ***
*** bug 270810 has been marked as a duplicate of this bug. ***
*** bug 270152 has been marked as a duplicate of this bug. ***
too late for 2.1 now, patch or not
*** Bug 266652 has been marked as a duplicate of this bug. ***
*** Bug 273836 has been marked as a duplicate of this bug. ***
*** Bug 309843 has been marked as a duplicate of this bug. ***
*** Bug 307677 has been marked as a duplicate of this bug. ***
kinda related to bug 259156 (show number of mails next to the mail component button in the left bottom corner) - at least i can imagine similar problems with that
fwiw i asked harish about this just before feature freeze, and he didn't push it either, so it misses another release. i also made an updated patch for a ui hackfest at some point - and yet it was completely ignored, never approved, so stayed uncommitted.
Harish: We would like to see this put in as soon as possible, please. Many users monitor their window list in the GNOME panel and the title bar change let's them know that they have new email. When we lost this feature in an earlier Evolution, I was amazed at the number of people that work this way. Thanks.
retargetting to 2.5; raising priority
I remember this was a shell patch and I had wanted Srini's approval on it. I shall reassign this to Srini for further handling.
i couldnt see the updated patch on the patches list. Can you passit out to me?
*poke* come on guys, this is extremely important for many customers! if the updated patch (see comment 18) has been on the e-p list then either not this year (bceause i've searched the archives) or without the bug number in the subject line. so what to do? anyway, i'm going to poke harish. (also removing wrong dependency)
andre, i understand this is a nice thing to do. But where about the patch? Im not able to find in archives. may be my search criteria is bad. We can get it in, if we can find the patch.
Srini, they are attached to this bug if i am not totally mistaken !!!
Srini, they are attached to this bug if i am not totally mistaken !!! You just need to ensure they apply on the HEAD now - i guess the updates to the patch mentioned are most likely just to let the patch apply cleanly.
ur right, but harish, i guess there was a updated patch to it, which was sent to the list. comment #18.
refering to comment 27: srini, see my comment 23! there is no patch on the list, at least not this year. so go ahead... ;-)
So finally. This patch goes in on head :).
well, the connector part has not been committed yet, so i _guess_ this is only fixed in evolution itself if i understand correctly. reopening - this is only partially fixed. changing status of second patch to 'committed'.
Committing the change to evo/mail/Evolution-Mail.idl seems to have created a lovely bug on Win32 because Evolution-Mail.idl now includes shell/Evolution-Shell.idl and not just Evolution-Component.idl. The problem is that the IDL compiler generates the same stub (and/or skel?) functions both in mail and shell... Things again happen to work out correctly on Linux, but on Win32 evo now crashes and burns. I am pretty certain that adding the same kind of guards to Evolution-Shell.idl as already had been added to Evolution-Component.idl will fix this, lemme see... (Hmm, both Evolution-Component.idl and Evolution-Shell.idl define a module called GNOME::Evolution. The one in Evolution-Component.idl lacks the Shell interface though. Is this duplication on purpose? Who really understands this stuff? And why is the interface ComponentView : Bonobo::Unknown defined twice, identically, in Evolution-Component.idl?)
Yup, it turns out that the following entry points were duplicated in libeshell-0.dll and libevolution-mail.dll: GNOME_Evolution_ComponentView__classid GNOME_Evolution_ComponentView__iinterface GNOME_Evolution_ComponentView__imethods GNOME_Evolution_ComponentView_getControls GNOME_Evolution_Component__classid GNOME_Evolution_Component__get_userCreatableItems GNOME_Evolution_Component__iinterface GNOME_Evolution_Component__imethods GNOME_Evolution_Component_createView GNOME_Evolution_Component_handleURI GNOME_Evolution_Component_interactive GNOME_Evolution_Component_quit GNOME_Evolution_Component_requestCreateItem GNOME_Evolution_Component_requestQuit GNOME_Evolution_Component_sendAndReceive GNOME_Evolution_Component_setLineStatus GNOME_Evolution_Component_upgradeFromVersion GNOME_Evolution_Listener__classid GNOME_Evolution_Listener__iinterface GNOME_Evolution_Listener__imethods GNOME_Evolution_Listener_complete GNOME_Evolution_ShellView__classid GNOME_Evolution_ShellView__iinterface GNOME_Evolution_ShellView__imethods GNOME_Evolution_ShellView_setComponent GNOME_Evolution_ShellView_setTitle GNOME_Evolution_Shell__classid GNOME_Evolution_Shell__iinterface GNOME_Evolution_Shell__imethods GNOME_Evolution_Shell_createNewWindow GNOME_Evolution_Shell_findComponent GNOME_Evolution_Shell_handleURI GNOME_Evolution_Shell_setLineStatus POA_GNOME_Evolution_ComponentView__fini POA_GNOME_Evolution_ComponentView__init POA_GNOME_Evolution_Component__fini POA_GNOME_Evolution_Component__init POA_GNOME_Evolution_Listener__fini POA_GNOME_Evolution_Listener__init POA_GNOME_Evolution_ShellView__fini POA_GNOME_Evolution_ShellView__init POA_GNOME_Evolution_Shell__fini POA_GNOME_Evolution_Shell__init TC_CORBA_sequence_GNOME_Evolution_CreatableItemType_struct TC_GNOME_Evolution_ComponentView_struct TC_GNOME_Evolution_Component_Failed_struct TC_GNOME_Evolution_Component_UnknownType_struct TC_GNOME_Evolution_Component_UnsupportedVersion_struct TC_GNOME_Evolution_Component_UpgradeFailed_struct TC_GNOME_Evolution_Component_struct TC_GNOME_Evolution_CreatableItemTypeList_struct TC_GNOME_Evolution_CreatableItemType_struct TC_GNOME_Evolution_CreatableItem_struct TC_GNOME_Evolution_Listener_struct TC_GNOME_Evolution_ShellView_struct TC_GNOME_Evolution_Shell_Busy_struct TC_GNOME_Evolution_Shell_ComponentNotFound_struct TC_GNOME_Evolution_Shell_InternalError_struct TC_GNOME_Evolution_Shell_InvalidURI_struct TC_GNOME_Evolution_Shell_NotFound_struct TC_GNOME_Evolution_Shell_NotReady_struct TC_GNOME_Evolution_Shell_UnsupportedSchema_struct TC_GNOME_Evolution_Shell_struct _ORBIT_skel_small_GNOME_Evolution_ComponentView_getControls _ORBIT_skel_small_GNOME_Evolution_Component__get_userCreatableItems _ORBIT_skel_small_GNOME_Evolution_Component_createView _ORBIT_skel_small_GNOME_Evolution_Component_handleURI _ORBIT_skel_small_GNOME_Evolution_Component_interactive _ORBIT_skel_small_GNOME_Evolution_Component_quit _ORBIT_skel_small_GNOME_Evolution_Component_requestCreateItem _ORBIT_skel_small_GNOME_Evolution_Component_requestQuit _ORBIT_skel_small_GNOME_Evolution_Component_sendAndReceive _ORBIT_skel_small_GNOME_Evolution_Component_setLineStatus _ORBIT_skel_small_GNOME_Evolution_Component_upgradeFromVersion _ORBIT_skel_small_GNOME_Evolution_Listener_complete _ORBIT_skel_small_GNOME_Evolution_ShellView_setComponent _ORBIT_skel_small_GNOME_Evolution_ShellView_setTitle _ORBIT_skel_small_GNOME_Evolution_Shell_createNewWindow _ORBIT_skel_small_GNOME_Evolution_Shell_findComponent _ORBIT_skel_small_GNOME_Evolution_Shell_handleURI _ORBIT_skel_small_GNOME_Evolution_Shell_setLineStatus Adding the same #pragma inhibit guard to Evolution-Shell.idl as we have in Evolution-Component.idl gets rid of the duplicates (leaving the entry points in question only in libeshell), and Evo works again. Whew.
The exchange patch has been committed too. Closing this bug
Woohoo. This is in 2.5.4 and works great. The user community will be very happy, thanks!
the names of the default folders (inbox, drafts, sent, outbox) are NOT translated in the window title. my folder list pane says "Eingang" (german for "Inbox"), but the window title says "Inbox". (the folders junk and trash are translated by the way.) reopening. please also see bug 274276!
Created attachment 67891 [details] [review] localizes the folder names in the window title andre, u can say "gracias" to me when we meet next... cuz the names of the folders r now translated in my window title. BTW, if u r still wondering watz "gracias" it is spanish for "thanks" my work is over with spanish as my system lang gotta switch back my system lang to gud ol' english....
i applied the patch to evolution 2.7.3 and it works perfectly for me. srini: commit?
Patch looks good to commit both to STABLE as well as CVS head.
patch attached to comment 36 committed both to stable and unstable branch: http://cvs.gnome.org/viewcvs/evolution/mail/mail-component.c?r1=1.133&r2=1.134 http://cvs.gnome.org/viewcvs/evolution/mail/mail-component.c?r1=1.132.2.1&r2=1.132.2.2 patch will be included in evolution 2.6.3 and evolution 2.7.4. thanks a lot.