After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 274276 - Filter editor's "Choose Folder" folders are not translated
Filter editor's "Choose Folder" folders are not translated
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.8.x
Other All
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 236276 327508 327510
 
 
Reported: 2005-03-31 15:43 UTC by Alexander Brausewetter
Modified: 2013-09-13 00:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
localizes the folder names in the filter n while importing mail (866 bytes, patch)
2006-06-24 13:16 UTC, arvind
needs-work Details | Review
localizes the folder names in the filter and while importing mail (1.25 KB, patch)
2006-07-23 12:55 UTC, arvind
committed Details | Review

Description Alexander Brausewetter 2005-03-31 15:43:53 UTC
When adding a email filter with a "move to folder" rule, you can choose the
folder with a button. When you click on it it show a localized list of your
folders. When you choose one, the localized dialog closes and the button
shows a the non-localized name of the folder chosen. It should display the
localized names like it does in the dialog.
Comment 1 André Klapper 2005-08-28 12:49:25 UTC
uhm, still valid in 2.3.8.
the strings *are* localized, sigh...
Comment 2 André Klapper 2005-08-28 14:37:53 UTC
it's also still the same in 2.3.8 when importing an email into evolution: when i
have to choose the target folder, in the folder selector window my folders
{inbox;sent;drafts;outbox} are translated, but after that, in the main importing
window, i see the english expression of that folder. just saw this when i was
importing an email for testing purposes.
Comment 3 André Klapper 2005-09-16 03:11:51 UTC
fix should be sth similar to

http://cvs.gnome.org/viewcvs/evolution/mail/em-folder-properties.c?r1=1.3.14.1&r2=1.3.14.2
Comment 4 André Klapper 2006-03-24 00:56:47 UTC
still in 2.6; also see bug 260354.
Comment 5 André Klapper 2006-06-23 12:14:25 UTC
still in 2.7.3, retargetting. rumours say that a fix is on the way. ;-)
Comment 6 arvind 2006-06-24 13:16:05 UTC
Created attachment 67937 [details] [review]
localizes the folder names in the filter n while importing mail

funny how rumours spread very fast.....

happened to hear abt the rumour n much more too :-)

well,this one's for u, andre.... cuz if it weren't for u, i ud've never finished the import mail part....

this patch fixes both the filter part n the import mail part...

had to shift my system lang yet again jus for the import mail part.....
lemme know if it works...

Tshus , andre..
Comment 7 André Klapper 2006-06-25 14:01:29 UTC
i applied the patch and it works well in both cases for me (importing mail and the message filter issue). should go into 2.6.3 and 2.7.4.

good work, arvind! thanks a lot for fixing this!!
Comment 8 Veerapuram Varadhan 2006-06-27 12:47:51 UTC
(In reply to comment #6)
> Created an attachment (id=67937) [edit]
> localizes the folder names in the filter n while importing mail
> 
Thanks for the patch.

However, I wouldn't want to return a "translated" string *ALWAYS*, rather would only translate when I show it to user. Marking the patch accordingly - Needs work.
Comment 9 André Klapper 2006-06-29 13:13:26 UTC
removing string keyword - this obviously does not _add_ a string.
Comment 10 arvind 2006-07-23 12:55:31 UTC
Created attachment 69417 [details] [review]
localizes the folder names in the filter and while importing mail

noted the change required..

this localizes the folder name only while showing the folder name to the user
Comment 11 André Klapper 2006-07-26 08:09:19 UTC
patch works for me. varadhan?
Comment 12 Veerapuram Varadhan 2006-07-26 09:14:51 UTC
Patch looks good.  Please commit it to both branch and head.
Comment 13 André Klapper 2006-07-26 09:26:21 UTC
committed to stable branch and CVS HEAD:
http://cvs.gnome.org/viewcvs/evolution/mail/em-folder-selection-button.c?r1=1.13&r2=1.13.8.1
http://cvs.gnome.org/viewcvs/evolution/mail/em-folder-selection-button.c?r1=1.14&r2=1.15

patch will be included in unstable evolution 2.7.91 and stable evolution 2.6.3.
closing as fixed.