GNOME Bugzilla – Bug 155870
The tasks are sized according to the amount of text in window titles.
Last modified: 2005-07-18 23:13:41 UTC
The tasks are sized according to the amount of text in window titles. Because applications which change their window titles frequently are very common, (Terminal, Mozilla, Red Carpet, etc.) this means that task sizes will often be changing sizes. Obviously if there is a lack of space for all the tasks, the tasks should be shrunk so they all fit. But they should not grow and shrink according to window titles.
Created attachment 32784 [details] [review] Unify the tasklist task size.
You know bugzilla searching must be too painful when people start filing duplicates of their own bugs...
*** Bug 85209 has been marked as a duplicate of this bug. ***
See also bug 125023.
*** Bug 139411 has been marked as a duplicate of this bug. ***
*** Bug 143118 has been marked as a duplicate of this bug. ***
*** Bug 85210 has been marked as a duplicate of this bug. ***
Benjamin: From taking a quick look at the patch, I could see that you introduced a new variable called b_width, which is only assigned but never read.
We are not in any freezes right now. libwnck hasn't branched, but that's merely because there hasn't been any patches that would cause the need for a branch before applying. I'm removing the BLOCKED_BY_FREEZE keyword.
Alex may be the most qualified person to look at this...
Man, i haven't looked at this code in a zillion years...
This patch would solve at the same time bug 160977 (introduced while solving bug 155868).
Could someone make a decision on this ? The tasklist is almost useless now because of bug 160977.
Vincent: You'll probably have to ping Havoc privately; he often misses bugzilla activity for libwnck. It may also be good to get some comments from Vincent Untz, due to his work in bug 125023.
+ total_width = BUTTON_MAX_WIDTH * n_cols; This should probably be: + total_width = b_width * n_cols;
Comment on attachment 32784 [details] [review] Unify the tasklist task size. Aside, if you add -p option to diff it's easier to see what's going on. A max height has to allow for large fonts. I would suggest something like MAX(24,font_height). Even that's a bit wrong; you really can't go chopping off the button bevel (the text may even "lose" if you do) so maybe just say that we need to honor size request height on the buttons. Of course, that's what the old code seems to do, so obviously I simply don't understand this patch ;-) I don't see how we can just chop off buttons if they exceed 24 pixels. Width I kind of get - I think it's potentially OK to just chop that especially if we ellipsize.
*** Bug 111961 has been marked as a duplicate of this bug. ***
Perhaps something can be done to the preferences also, because the "Window List Size" settings are behaving quite strange... I mean the "Minimus size" and "Maximum size" settings, setting the maximum size doesn't seem to do anything...
Moving to the right component. Sorry for the spam.
This could also fix the fact that when you check email in evolution, it opens briefly a "Send & receive mail" window, that inserts itself into the tasklist and shuffles everything. This happens with evolution, but also with any app that opens a window and closes it after a very short while. It looks really weird.
Consolidating; see bug 310809. *** This bug has been marked as a duplicate of 310809 ***