After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789886 - Add missing features in MediaSDK plugin [metabug]
Add missing features in MediaSDK plugin [metabug]
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 786879 789751 789752 789847 790312 790752 791479 791599 791637 792260 792589 793236 793411 793412 793413 793414 793415 793495 793525 793705 793707 793708 793741 793781 793782 793784 793786 793787 793864 793865 793867 793869 793872 793873 793904 793906 794276 794817 794851 794944 794946 794991 795707 795783 796118 796119 796232 796459 796460 796461 796462 796464 796465 796467 796468 796469 796521 796522 796566 796699 796819
Blocks:
 
 
Reported: 2017-11-03 21:11 UTC by sreerenj
Modified: 2018-11-03 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description sreerenj 2017-11-03 21:11:55 UTC
The gst-msdk plugin is missing many of the features required for customers.
This is a meta bug for tracking media-sdk GStreamer plugin development and also to discuss the design options.

Please file separate bugs for each feature listing here.
Comment 1 sreerenj 2017-11-03 21:40:51 UTC
Add Missing Decoders:(Open source MSDK might not be supporting all codecs)

* MPEG-2
* VC1
* VP9 (8 & 10 bit)

Add Missing Encoders:

* VP9 (8 & 10 bit)
* HEVC (10 bit)

Add VPP support
* CSC
* Scaling
* De-interlacing
* Denoise
* Sharpening
* Color-balance (Hue, Saturation, Brightness and contrast)

* Add dma-buffer sharing support
Comment 2 sreerenj 2017-11-03 21:55:48 UTC
To Discuss: Do we need one more render for msdk?

AFAIK, MediaSDK itself is not providing any rendering APIs. I don't think we need any specific rendering plugin "msdksink".

One option is to get VASurfaceID out of msdk surface and use vaapisink as renderer.

But even vaapisink is not something we need in future, everything through dmabuf + glimagesink should be an ideal option.
Comment 3 Hyunjun Ko 2017-11-06 05:44:42 UTC
(In reply to sreerenj from comment #2)

> But even vaapisink is not something we need in future, everything through
> dmabuf + glimagesink should be an ideal option.


Totally I agree with this. msdk decoder(dmabuf) + glimagesink should not be less than msdk's own renderer.
Comment 4 Hyunjun Ko 2017-11-06 05:46:19 UTC
I would add something more to be done.
* Support buffer pool.
* Support avc stream-type for h264 decoder
* Supoort hvc1 stream-type for h265 decoder.

Currently I'm working on buffer pool support.
Comment 5 sreerenj 2017-11-07 04:54:54 UTC
(In reply to Hyunjun Ko from comment #4)
> I would add something more to be done.
> * Support buffer pool.
> * Support avc stream-type for h264 decoder
> * Supoort hvc1 stream-type for h265 decoder.
> 
> Currently I'm working on buffer pool support.

This might be overlapping with what Slomo is currently doing: https://bugzilla.gnome.org/show_bug.cgi?id=789751#c11

Vpp and a Common buffer pool mechanism are the major features needed.

I am not sure whether we can efficiently implement all gstreamer use cases (which involves memory/allocator/bufferpool related stuffs) by only using mfxFrameSurface.

If we end up dealing with underlined VASurface, it might require the same code base in gstreamer-vaapi for pools and allocators and in that case, we may think of a common library for gst-msdk and gstreamer-vaapi :)
Comment 9 GStreamer system administrator 2018-11-03 14:15:06 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/628.