After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793414 - msdk: refactor removing duplicated code in encoder and decoder.
msdk: refactor removing duplicated code in encoder and decoder.
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 789886
 
 
Reported: 2018-02-13 07:53 UTC by Hyunjun Ko
Modified: 2018-11-03 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Hyunjun Ko 2018-02-13 07:53:23 UTC 
There are some duplicate code and can be placed in one place, so called, gstmsdkutil.c.

Let's refactor and clean it up.
Comment 1 Hyunjun Ko 2018-03-28 03:30:12 UTC 
Currently, I'm planning to move create_msdk_buffer_pool from each element to gstmsdkutils.c

After patches in bug #793705 land, there are 3 similar code to create bufferpool.
I would work on this first after the vpp patches land.

Another one is for MsdkSurface which is also implemented in each element.
There could be 2 apis and 1 struct in gstmsdkutils, something like gst_msdk_surface_new and gst_msdk_surface_free for GstMsdkSurface struct.
Comment 2 GStreamer system administrator 2018-11-03 14:18:20 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/658.