After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788454 - Text diff foreground / background colors are incompatible with dark themes (vs dark variants)
Text diff foreground / background colors are incompatible with dark themes (v...
Status: RESOLVED OBSOLETE
Product: gitg
Classification: Applications
Component: gitg
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-02 23:13 UTC by Jean-François Fortin Tam
Modified: 2018-05-22 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (68.67 KB, image/png)
2017-10-02 23:13 UTC, Jean-François Fortin Tam 		Details

Description Jean-François Fortin Tam 2017-10-02 23:13:21 UTC 
Created attachment 360806 [details]
screenshot

So this was initially an issue with bug #750803, which got fixed, and then got re-fixed in bug #765727... but now the issue is that GNOME has removed the global dark theme "variant" switch from GNOME 3.26 from a users' perspective, and from what I realized by discussing with folks in #gnome-design is that we're now meant to have real separate dark themes; so in 3.26 to switch to dark mode, you have gnome-tweak-tool (or cron...) switch the GTK theme from "Adwaita" to "Adwaita-dark".

The problem is that gitg doesn't support that properly, as you can see in the attached screenshot...

As far as I understand it it should now detect such dark themes or the actual colors of the theme.
Comment 1 Jean-François Fortin Tam 2017-10-02 23:21:00 UTC 
For what it's worth, I cross-filed this bug report in Meld also, which has the same issue: bug #788455
Comment 2 GNOME Infrastructure Team 2018-05-22 13:23:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/97.