GNOME Bugzilla – Bug 788455
Text diff foreground / background colors are incompatible with dark themes (vs dark variants)
Last modified: 2018-05-25 21:23:33 UTC
Created attachment 360807 [details] screenshot It seems that Meld is affected in the same way as Gitg when it comes to the future of dark themes (GNOME 3.26+): see bug #788454... In short: Meld adjusts its colors properly if the "global dark GTK variant" setting is switched on, but that setting doesn't exist anymore in newer versions, so now users might need to actually use real dark themes (like "Adwaita-dark"), which Meld doesn't handle (see attached screenshot).
I'm sorry, but I'm confused about what's happened here. That setting still appears to exist in current GTK+ 3 (at least it looks like it to me) and it's not marked as deprecated or anything. Could you point me to any docs or NEWS or whatever that explains this?
Actually that's a removal planned for 3.28, sorry: https://jeremy.bicha.net/2017/08/29/gnome-tweaks-3-25-91/
Thanks for the link. I don't really think that the minor points raised in that blog post justify breaking existing applications, but whatever. I can't find any indication of how an application is actually supposed to support dark themes in this way. There doesn't appear to be any kind of structured information to say "this is a dark theme", best I can tell. Do you happen to know whether other applications are doing anything sensible, or is this a case of "look at the background of a random widget and see whether it's dark or not"?
I've just pushed a change that takes a random guess whether we're running under a dark theme. I've tested this on Adwaita and it seems to work okay, but please let me know if it doesn't work with something else. Thanks for your bug report.
Hi, I use cinnamon and I want to use gitg, I've tried adawaita and I see that he has problems with dark themes, if you notice here I'll give you some screenshots using different dark themes, https://imgur.com/a/gUO4uL9 I want to use gitg, this application is good but the problem of the dark subject you spoil the day to day you know. maybe one of the options would be to be able to choose the theme in the gitg options, if you notice the problem is in the text sheet where you see the code, if you have an option in gitg settings to choose colors or themes, so one would choose to their liking and it would not depend on the theme of the system. I say as an appropriate option. if you look at the images, I'm just putting some of the most popular topics out there. I do not know if there will be more or better, but if you see what the problem is, you will understand it.
This is a bug for Meld, not gitg. You want https://gitlab.gnome.org/GNOME/gitg/issues/97