GNOME Bugzilla – Bug 765727
Diff/index view colors should be inverted in dark themes
Last modified: 2016-10-24 00:17:05 UTC
This worked fine in 3.18 Compare these screenshots: 3.18-light: http://storage1.static.itmages.com/i/16/0428/h_1461852434_6110386_d68317e647.png 3.18-dark: http://storage2.static.itmages.com/i/16/0428/h_1461852488_3497758_8b14b83707.png 3.20-light: http://storage4.static.itmages.com/i/16/0428/h_1461852544_7067484_194a86e3d2.png 3.20-dark: http://storage9.static.itmages.com/i/16/0428/h_1461852570_5428190_85f5a66d66.png The last one is unusable. Using 3.20.3 GTK with a compatible theme.
We do have code in place for adwaita dark. I guess you are using the ubuntu theme?
I am on manjaro with lxdm. The system just moved to 3.20 GTK. I tried quite a few supposedly compatible dark themes, those in the screenshots are Vertex-Maia(-Dark). It seems I don't have adwaita dark available by default. I'll need to get it from AUR
Nevermind, I apparently needed to use 'prefer dark'. It does not work with GTK2 theming nor QT. I hate GTK...
well, these are colors hard coded in gitg, we detect the user has a dark theme by checking that setting. Clearly if you set a dark theme but that setting is not set then we will not detect it in the app... I am willing to hear about better options here...
Well, yes that works for me as well when NOT using adwaita. Sorry for venting. To summarize: 1) use a multi-toolkit dark-only theme like Vertex-Maia-Dark 2) set gtk-application-prefer-dark-theme=1 in .config/gtk-3.0/settings.ini 3) profit
See that this is IMHO a downstream bug in Vertex-Maia. That theme should detect if prefer-dark is set and use Vertex-Maia if disabled or Vertex-Maia-Dark if enabled. You might want to report this downstream. Thanks anyway for reporting here.
Hello, I'm back :/ Here is how it now looks on 22 with syntax highlighting: https://i.imgur.com/bog9hVa.png Any suggestions how to adjust this? Where do syntax colors come from? I guess it's hard to make this feature work with white on black. I need to revert that somehow...