GNOME Bugzilla – Bug 778167
general: add support for Meson
Last modified: 2017-05-24 11:24:13 UTC
This patch adds support for the Meson build system.
Created attachment 344914 [details] [review] general: add support for Meson
Created attachment 344916 [details] [review] general: add support for Meson
Created attachment 344919 [details] [review] general: add support for Meson
Something might still be subtly broken. So far I’ve fixed: libnautilus-extension not being installed, libnautilus-extension headers being installed in the wrong dir, nautilus-autorun-software not being built, LOCALEDIR not being prefixed, resulting in broken translations
Created attachment 344926 [details] [review] general: add support for Meson Fixed extensiondir.
Created attachment 346592 [details] [review] Drop git.mk
Created attachment 346593 [details] [review] general: add support for Meson
Created attachment 346595 [details] [review] general: add support for Meson Since it’s 2017 already, Nautilus should use a build system that doesn’t take longer to set up the build than it takes to actually build. An observed build time of roughly one-fifth of what it took Autotools is more than reason enough to add support for Meson. Along with that, this commit adds a convenience script (https://github.com/meitar/git-archive-all.sh) to generate a tarball for releases, since we use libgd as a submodule and Meson does not handle source distributions.
Created attachment 346596 [details] [review] Drop git.mk This commit removes git.mk and adds hand-written gitignore files. That is needed to ignore build/, which is the directory of choice for Meson builds.
Created attachment 346598 [details] [review] general: add support for Meson Since it’s 2017 already, Nautilus should use a build system that doesn’t take longer to set up the build than it takes to actually build. An observed build time using Ninja of roughly one-fifth of what it took Autotools is more than reason enough to add support for Meson. Along with that, this commit adds a convenience script (https://github.com/meitar/git-archive-all.sh) to generate a tarball for releases, since we use libgd as a submodule and Meson does not handle source distributions.
Created attachment 346599 [details] [review] general: drop git.mk This commit removes git.mk and adds hand-written gitignore files. That is needed to ignore build/, which is the directory of choice for Meson builds.
Created attachment 346601 [details] [review] general: add support for Meson Since it’s 2017 already, Nautilus should use a build system that doesn’t take longer to set up the build than it takes to actually build. An observed build time using Ninja of roughly one-fifth of what it took Autotools is more than reason enough to add support for Meson. Along with that, this commit adds a convenience script (https://github.com/meitar/git-archive-all.sh) to generate a tarball for releases, since we use libgd as a submodule and Meson does not handle source distributions.
Created attachment 346606 [details] [review] general: add support for Meson Since it’s 2017 already, Nautilus should use a build system that doesn’t take longer to set up the build than it takes to actually build. An observed build time using Ninja of roughly one-fifth of what it took Autotools is more than reason enough to add support for Meson. Along with that, this commit adds a convenience script (https://github.com/meitar/git-archive-all.sh) to generate a tarball for releases, since we use libgd as a submodule and Meson does not handle source distributions.
Created attachment 346608 [details] [review] general: add support for Meson Since it’s 2017 already, Nautilus should use a build system that doesn’t take longer to set up the build than it takes to actually build. An observed build time using Ninja of roughly one-fifth of what it took Autotools is more than reason enough to add support for Meson. Along with that, this commit adds a convenience script (https://github.com/meitar/git-archive-all.sh) to generate a tarball for releases, since we use libgd as a submodule and Meson does not handle source distributions.
Review of attachment 346599 [details] [review]: Since we are just matching what git.mk was doing, this looks good to me. Might worth a revisit of all of this stuff later on when we don't have autotools anymore.
Review of attachment 346608 [details] [review]: As we reviewed on IRC, except for the commit message mentioning the (now unused) git-archive-all, this looks good to me! Impressive work!!!
Created attachment 346609 [details] [review] general: add support for Meson Since it’s 2017 already, Nautilus should use a build system that doesn’t take longer to set up the build than it takes to actually build. An observed build time using Ninja of roughly one-fifth of what it took Autotools is more than reason enough to add support for Meson. Along with that, this commit adds a convenience script to generate a tarball for releases, since we use libgd as a submodule and Meson does not handle source distributions.
Attachment 346599 [details] pushed as 7283003 - general: drop git.mk Attachment 346609 [details] pushed as ed5652c - general: add support for Meson