After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779669 - Meson doesn't run glib-compile-schemas
Meson doesn't run glib-compile-schemas
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
master
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-06 20:24 UTC by Carlos Soriano
Modified: 2017-03-10 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: compile gschemas after installing (1.15 KB, patch)
2017-03-07 09:29 UTC, Ernestas Kulik
none Details | Review
meson: move scripts to a directory (1.49 KB, patch)
2017-03-07 09:30 UTC, Ernestas Kulik
none Details | Review
meson: compile gschemas after installing (1.23 KB, patch)
2017-03-08 13:12 UTC, Ernestas Kulik
committed Details | Review
meson: move scripts to a directory (1.63 KB, patch)
2017-03-08 13:12 UTC, Ernestas Kulik
committed Details | Review

Description Carlos Soriano 2017-03-06 20:24:35 UTC
Seems it's done by jhbuild. I wonder whether it should be done by meson. I was doing an app locally with meson and I integrated it with it in the past, and it's extremely convenient even for non-jhbuild builds.
Comment 1 Ernestas Kulik 2017-03-07 09:29:58 UTC
Created attachment 347368 [details] [review]
meson: compile gschemas after installing

As some users or developers might choose to install repo builds, they
would also have to compile the installed GSettings schema manually. This
commit adds a script that does that post-install.
Comment 2 Ernestas Kulik 2017-03-07 09:30:03 UTC
Created attachment 347369 [details] [review]
meson: move scripts to a directory

This commit moves scripts used in Meson to a separate directory to
declutter the root directory.
Comment 3 Carlos Soriano 2017-03-08 11:41:56 UTC
Review of attachment 347368 [details] [review]:

::: meson.build
@@ +130,3 @@
 endif
+
+meson.add_install_script ('post_install.sh')

I think you can call it compile_schemas.sh since is more descriptive and we don't have anything else to go in the post install phase.

Also, can you add the comment inside the script on top of this line instead?
Comment 4 Carlos Soriano 2017-03-08 11:45:06 UTC
Review of attachment 347369 [details] [review]:

can you rename the folder to build-scripts?

We have more scripts than just those two (uncrustify, etc)
Comment 5 Ernestas Kulik 2017-03-08 13:12:24 UTC
Created attachment 347480 [details] [review]
meson: compile gschemas after installing

As some users or developers might choose to install repo builds, they
would also have to compile the installed GSettings schema manually. This
commit adds a script that does that post-install.
Comment 6 Ernestas Kulik 2017-03-08 13:12:32 UTC
Created attachment 347481 [details] [review]
meson: move scripts to a directory

This commit moves scripts used in Meson to a separate directory to
declutter the root directory.
Comment 7 Carlos Soriano 2017-03-08 14:30:56 UTC
Review of attachment 347480 [details] [review]:

LGTM thanks!
Comment 8 Carlos Soriano 2017-03-08 15:06:28 UTC
Review of attachment 347481 [details] [review]:

+1
Comment 9 Ernestas Kulik 2017-03-08 15:52:21 UTC
Attachment 347480 [details] pushed as 9419c26 - meson: compile gschemas after installing
Attachment 347481 [details] pushed as f72f5f3 - meson: move scripts to a directory