After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779472 - meson: set correct libnautilus-extension version in .pc
meson: set correct libnautilus-extension version in .pc
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-02 13:08 UTC by Ernestas Kulik
Modified: 2017-03-10 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: set correct libnautilus-extension version in .pc (1.37 KB, patch)
2017-03-02 13:08 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2017-03-02 13:08:04 UTC
Currently, when building with Meson, the version of the pkg-config file
for libnautilus-extension is set to the version of the library itself.
This is incompatible with how it was before - the version was set to the
version of Nautilus. That breaks some modules that build extensions
(e.g. file-roller).
Comment 1 Ernestas Kulik 2017-03-02 13:08:10 UTC
Created attachment 347063 [details] [review]
meson: set correct libnautilus-extension version in .pc
Comment 2 Carlos Soriano 2017-03-03 12:24:33 UTC
Review of attachment 347063 [details] [review]:

Yes, thanks!
(I commit myself, I want to have this for 3.23.91 since I'm going to release with meson)
Comment 3 Carlos Soriano 2017-03-03 12:25:20 UTC
btw this shouldn't be like that, they should check for the libnautilus version :/ but if we have been doing this for some time... better to not break it
Comment 4 Ernestas Kulik 2017-03-03 12:30:32 UTC
(In reply to Carlos Soriano from comment #3)
> btw this shouldn't be like that, they should check for the libnautilus
> version :/ but if we have been doing this for some time... better to not
> break it

Yeah, that’s how I imagined things worked. file-roller could be patched, but I don’t know how other projects behave.
Comment 5 Carlos Soriano 2017-03-03 16:08:02 UTC
Attachment 347063 [details] pushed as fd50ac5 - meson: set correct libnautilus-extension version in .pc