After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779603 - Meson build fails on Debian build servers
Meson build fails on Debian build servers
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-05 06:59 UTC by Ernestas Kulik
Modified: 2017-03-10 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: update submodule only if git is installed (1.27 KB, patch)
2017-03-05 07:00 UTC, Ernestas Kulik 		none Details | Review
meson: update submodule only if it doesn’t exist (1.55 KB, patch)
2017-03-05 19:51 UTC, Ernestas Kulik 		none Details | Review
meson: update submodule only if it doesn’t exist (1.58 KB, patch)
2017-03-06 15:42 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-03-05 06:59:47 UTC 
Some build servers don’t have git installed, which makes the tarball
build fail when trying to update the libgd submodule.
Comment 1 Ernestas Kulik 2017-03-05 07:00:00 UTC 
Created attachment 347253 [details] [review]
meson: update submodule only if git is installed
Comment 2 Ernestas Kulik 2017-03-05 19:51:39 UTC 
Created attachment 347278 [details] [review]
meson: update submodule only if it doesn’t exist

Some build servers don’t have git installed, which makes the tarball
build fail when trying to update the libgd submodule. This commit adds a
check for the existence of the root meson.build of libgd before running
git.
Comment 3 Ernestas Kulik 2017-03-05 19:52:14 UTC 
So I heard you like scripts. :)
Comment 4 Carlos Soriano 2017-03-06 13:25:50 UTC 
Review of attachment 347278 [details] [review]:

:( more scripts... but yeah I think is the way to go. Feel free to commit after this change:

::: meson.build
@@ -103,3 @@
 subdir ('libnautilus-extension')
 
-message ('Updating libgd submodule…')

I like the message. Change it to "checking libgd..." or so)
Comment 5 Ernestas Kulik 2017-03-06 15:42:51 UTC 
Created attachment 347322 [details] [review]
meson: update submodule only if it doesn’t exist

Some build servers don’t have git installed, which makes the tarball
build fail when trying to update the libgd submodule. This commit adds a
check for the existence of the root meson.build of libgd before running
git.
Comment 6 Ernestas Kulik 2017-03-06 15:44:05 UTC 
Attachment 347322 [details] pushed as dc57c21 - meson: update submodule only if it doesn’t exist