After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 76993 - schema ignores install prefix for default background
schema ignores install prefix for default background
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
unspecified
Other All
: High minor
: 2.0.0
Assigned To: jacob berkman
Luis Villa
: 76432 77144 77924 84644 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-03-30 16:24 UTC by Jody Goldberg
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
patch to handle non-existant files more gracefully at startup, and set the default background image to nothing (3.54 KB, patch)
2002-05-16 20:36 UTC, jacob berkman
none Details | Review

Description Jody Goldberg 2002-03-30 16:24:55 UTC
libgnom/schemas/desktop_gnome_background.schemas
    <key>/schemas/desktop/gnome/background/picture_filename</key>
    <default>/usr/share/nautilus/patterns/dark-gnome.jpg</default>

1) /use/share should default to the libgnome install prefix in
preference to /usr.  Its not correct but it is more likely to be correct.

2) Should the default not be installed in libgnomeui rather than nautilus ?
Comment 1 Luis Villa 2002-05-10 03:32:17 UTC
Did this get fixed, Jody? Also, I'm  little unclear on the
consequences if not...
Comment 2 Jody Goldberg 2002-05-10 04:03:25 UTC
no it did not.
On a system without nautilus or with nautilus in a different prefix that /usr
the background capplet will fail to find the default sample.
Comment 3 Luis Villa 2002-05-10 06:08:36 UTC
*** Bug 77924 has been marked as a duplicate of this bug. ***
Comment 4 Luis Villa 2002-05-10 06:08:57 UTC
*** Bug 77144 has been marked as a duplicate of this bug. ***
Comment 5 Luis Villa 2002-05-10 06:11:00 UTC
Minor but the repetition makes me think this might end up being more
common than we'd like. Oh buildmaster, can you make this use $PREFIX
somehow?
Comment 6 jacob berkman 2002-05-10 16:46:39 UTC
the pixmap it refers to is installed by nautilus, so the schema really
needs to point to nautilus' prefix and not libgnome's.  however, it's
impossible for libgnome to know this at build time.

the right fix is to include an image in libgnome, or set the default
to be nothing.

trivial to do either.
Comment 7 Anders Carlsson 2002-05-10 20:15:54 UTC
I think we're ok with just using a solid color for 2.0. Distributions
can change it if they want.
Comment 8 Luis Villa 2002-05-13 15:14:58 UTC
Yeah, I think I'm with Anders... just set it to blank or a color and
close it.
Comment 9 jacob berkman 2002-05-13 16:59:40 UTC
setting it to an empty string exposes some bugs in the background
properties capplet which i will need to fix before committing a fix here.

(my guess is those bugs prompted a default image to be added, which
causes this bug)
Comment 10 jacob berkman 2002-05-14 22:40:08 UTC
*** Bug 76432 has been marked as a duplicate of this bug. ***
Comment 11 jacob berkman 2002-05-14 22:40:39 UTC
i will fix this this week.
Comment 12 jacob berkman 2002-05-16 20:35:08 UTC
jody, anders:

can i commit this patch?
Comment 13 jacob berkman 2002-05-16 20:36:04 UTC
Created attachment 8517 [details] [review]
patch to handle non-existant files more gracefully at startup, and set the default background image to nothing
Comment 14 Jody Goldberg 2002-05-16 21:04:13 UTC
Looks good.  I like the idea of defaulting to nothing in place of assuming that
nautilus is installed.
Comment 15 jacob berkman 2002-05-16 22:23:19 UTC
fixes committed.
Comment 16 jacob berkman 2002-06-11 19:55:15 UTC
*** Bug 84644 has been marked as a duplicate of this bug. ***