After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761624 - [tracker] match nmm:composer as author for audio
[tracker] match nmm:composer as author for audio
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on: 763009
Blocks:
 
 
Reported: 2016-02-06 10:56 UTC by Marinus Schraal
Modified: 2016-05-14 00:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
set author to nmm:composer (529 bytes, patch)
2016-02-06 10:56 UTC, Marinus Schraal 		none Details | Review
composer to GRL_METADATA_KEY_COMPOSER (973 bytes, patch)
2016-03-02 19:54 UTC, Marinus Schraal 		accepted-commit_now Details | Review
core: Add GRL_METADATA_KEY_ALBUM_DISC (4.25 KB, patch)
2016-05-13 11:58 UTC, Marinus Schraal 		rejected Details | Review
tracker: Add mapping for composer key (1022 bytes, patch)
2016-05-13 16:44 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2016-02-06 10:56:33 UTC 
Created attachment 320526 [details] [review]
set author to nmm:composer

gnome-music bug #705094 wants to add a composer specific field & search. Currently grilo does not expose this field.

I suggest to either use the GRL_METADATA_KEY_AUTHOR field for this purpose as the attached patch does or add another GRL_METADATA_KEY_COMPOSER to core grilo.

The 2nd option I don't know what an author field would be for a musical piece if it wasn't the composer, so it seems a fair match. Although a clear key name would have it's benefits.
Comment 1 Phillip Wood 2016-02-07 14:24:50 UTC 
I'd suggest using GRL_METADATA_KEY_COMPOSER as it's unambiguous. The AUTHOR key might be the lyricist
Comment 2 Bastien Nocera 2016-03-02 12:53:39 UTC 
Comment on attachment 320526 [details] [review]
set author to nmm:composer

Marking as needs-work, as per comment 1
Comment 3 Marinus Schraal 2016-03-02 19:54:08 UTC 
Created attachment 322915 [details] [review]
composer to GRL_METADATA_KEY_COMPOSER

Use the requested GRL_METADATA_KEY_COMPOSER instead.
Comment 4 Bastien Nocera 2016-03-03 11:52:33 UTC 
Review of attachment 322915 [details] [review]:

That looks fine.
Comment 5 Marinus Schraal 2016-05-13 11:58:30 UTC 
Created attachment 327784 [details] [review]
core: Add GRL_METADATA_KEY_ALBUM_DISC

Addition of GRL_METADATA_KEY_ALBUM_DISC: gives the specific disc number
on which the media is located on a physical multi-disc set album.

https://bugzilla.gnome.org/show_bug.cgi?id=761868
Comment 6 Marinus Schraal 2016-05-13 12:00:22 UTC 
Comment on attachment 327784 [details] [review]
core: Add GRL_METADATA_KEY_ALBUM_DISC

sent to the wrong bug no.
Comment 7 Marinus Schraal 2016-05-13 16:44:45 UTC 
Created attachment 327808 [details] [review]
tracker: Add mapping for composer key

Add support for GRL_METADATA_KEY_COMPOSER.