GNOME Bugzilla – Bug 761868
[PATCH] add album disc key
Last modified: 2016-05-13 15:03:27 UTC
Created attachment 320891 [details] [review] add GRL_METADATA_ALBUM_DISC Adds GRL_METADATA_ALBUM_DISC for music albums that are on several discs. This key would return the disc the song is on. Intended to be used by gnome-music.
Review of attachment 320891 [details] [review]: The API docs need work. ::: src/data/grl-media.c @@ +1748,3 @@ + * grl_media_set_album_disc: + * @media: the media instance + * @album_disc: the audio's album disc disc name? @@ +3142,3 @@ + * @media: the media instance + * + * Returns: the disc number of the media Well, the media doesn't have a disc number, it's not on a disc. ::: src/grl-metadata-key.c @@ +645,3 @@ + "The disc number of the album", + -1, G_MAXINT, + -1, Why is -1 the default value? "disc 0" is probably already enough to detect that it's unset, no?
Created attachment 322850 [details] [review] add GRL_METADATA_ALBUM_DISC It is not easy to convey what an album disc is succinctly, hope this is better.
Created attachment 327785 [details] [review] core: Add GRL_METADATA_KEY_ALBUM_DISC Addition of GRL_METADATA_KEY_ALBUM_DISC: gives the specific disc number on which the media is located on a physical multi-disc set album. https://bugzilla.gnome.org/show_bug.cgi?id=761868 https://bugzilla.gnome.org/show_bug.cgi?id=761624
Created attachment 327788 [details] [review] core: add GRL_METADATA_KEY_ALBUM_DISC Addition of GRL_METADATA_KEY_ALBUM_DISC: gives the specific disc number on which the media is located on a physical multi-disc set album.
I renamed the key GRL_METADATA_KEY_ALBUM_DISC_NUMBER, to make it clear it was a number (and not possibly a string), and changed the grammar slightly.