GNOME Bugzilla – Bug 763009
[PATCH] add several audio related keys
Last modified: 2016-05-13 15:14:55 UTC
Created attachment 322912 [details] [review] composer key Add keys for composer, album artist & codec.
Created attachment 322913 [details] [review] album artist
Created attachment 322914 [details] [review] codec key
Needs the patch in https://bugzilla.gnome.org/show_bug.cgi?id=761868 for these patches to apply cleanly.
Review of attachment 322912 [details] [review]: ::: src/data/grl-media.c @@ +3236,3 @@ + * Returns: the n-th composer of the media + * + * Since: 0.3.0 Why is this one since 0.3.0?
Review of attachment 322913 [details] [review]: Sure.
Review of attachment 322914 [details] [review]: This is broken. Audio containers can have multiple tracks with different codecs. Video containers can have video tracks with multiple codecs. A single codec won't help. Look for the GStreamer plugin in bugzilla for a way to get properly formatted metadata from the container about the different audio/video track codecs.
Created attachment 323004 [details] [review] composer key 0.3.0 was an oversight
(In reply to Bastien Nocera from comment #6) > Review of attachment 322914 [details] [review] [review]: > > This is broken. Audio containers can have multiple tracks with different > codecs. Video containers can have video tracks with multiple codecs. A > single codec won't help. Yeah makes sense. Let's drop that from here for now and I'll see if i can cook something up later and drop it in a new bug.
Created attachment 327786 [details] [review] core: Add GRL_METADATA_KEY_COMPOSER Add GRL_METADATA_KEY_COMPOSER, defines the composer(s) of the media.
Created attachment 327787 [details] [review] core: Add GRL_METADATA_KEY_ALBUM_ARTIST Add GRL_METADATA_KEY_ALBUM_ARTIST, defines the main artist of the album from which the media originates.
Attachment 327786 [details] pushed as e61f217 - core: Add GRL_METADATA_KEY_COMPOSER Attachment 327787 [details] pushed as e9be911 - core: Add GRL_METADATA_KEY_ALBUM_ARTIST (after rebasing)