After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705094 - Display more details on Album view
Display more details on Album view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 768475 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-29 18:01 UTC by Phillip Wood
Modified: 2016-11-02 17:08 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
add composer search & AlbumWidget label (15.76 KB, patch)
2016-02-06 11:45 UTC, Marinus Schraal
none Details | Review
composer v2 (17.07 KB, patch)
2016-02-07 10:22 UTC, Marinus Schraal
none Details | Review

Description Phillip Wood 2013-07-29 18:01:29 UTC
For classical music it would be really useful if gnome-music supported the composer tag. An equivalent of the artist view for composers would be great.
Comment 1 Vadim Rutkovsky 2013-08-12 16:14:44 UTC
I don't think a separate 'Composer' view makes sense, but add 'composer' field as a valid author makes sense. At least, we can display more information about the album on album view
Comment 2 Phillip Wood 2013-08-16 09:04:42 UTC
A composer field would be very useful for searching and displaying composer information would be great as well. 

>I don't think a separate 'Composer' view makes sense

I think it depends on your music collection. For classical music I find the composer view on my ipod and phone much more use than the artist view as I know who the music is written by but cannot always remember the artist.
Comment 3 Arnel Borja 2014-04-02 10:59:41 UTC
I think we cannot implement this one:
* The new view will probably not be used by most users
* Adding more views will add more buttons in the header and will block bugs that have window size issues like bug 700022

Maybe we could ask the designers what they think about this.
Comment 4 Phillip Wood 2014-04-02 11:15:11 UTC
If a composer view does not make sense then having support for composer tags in the search and maybe displaying them with the album details would still be very useful for classical music.
Comment 5 Vadim Rutkovsky 2014-04-02 11:16:40 UTC
(In reply to comment #4)
> If a composer view does not make sense then having support for composer tags in
> the search and maybe displaying them with the album details would still be very
> useful for classical music.

Agree on this one, I'd also display some other details from tags (or a link to last.fm/whatever for more details on album/performer)
Comment 6 Allan Day 2014-04-17 18:01:37 UTC
(In reply to comment #4)
> If a composer view does not make sense then having support for composer tags in
> the search and maybe displaying them with the album details would still be very
> useful for classical music.

Makes sense (easiest UI review ever!)
Comment 7 Phillip Wood 2014-04-18 11:02:09 UTC
(In reply to comment #6)
> 
> Makes sense (easiest UI review ever!)

That's great, now that sound-juicer will write composer tags it would be nice to be able to use them in gnome-music.
Comment 8 Allan Day 2016-01-06 13:16:33 UTC
Removing the available whiteboard - we're not really using it any more.
Comment 9 Marinus Schraal 2016-02-06 11:45:18 UTC
Created attachment 320529 [details] [review]
add composer search & AlbumWidget label

First go at a patch to add this feature. Needs patches from bug #761625 and bug #761624 (grilo plugins) applied first.

A couple of questions still open :
* if we have multiple composers on an album, how do we display them? (currently it shows just the one for a full album, probably the one tracker first encounters)
* should we display this label by default or just when the info is available?
* in search view, there is currently no indication of a composer. I guess we could add it to the song view (besides the artist) or should we replace the artist (which could look strange).

Note that I think the tracker queries have gotten quite a bit heavier to accommodate the search (slower? hard to actually reliably measure), to the point where it might be sensible to split them up in general and search queries to speed them up.
Comment 10 Marinus Schraal 2016-02-07 10:22:49 UTC
Created attachment 320568 [details] [review]
composer v2

updated patch, fixes queries up a bit and squashes some search bugs
Comment 11 Marinus Schraal 2016-07-06 08:43:22 UTC
*** Bug 768475 has been marked as a duplicate of this bug. ***
Comment 12 Friedrich Herbst 2016-07-06 08:56:03 UTC
I didn't know about this and filed Bug 768475, sorry. What about introducing a GSettings key for replacing the artists view with a composer view?
Comment 13 Marinus Schraal 2016-07-06 09:12:37 UTC
It's too invasive to hide behind a gsetting.

If one could come up with a fresh design that would seamlessly incorporate both modes, that would be far more interesting.
Comment 14 Friedrich Herbst 2016-07-06 09:23:56 UTC
Maybe there could be a classical music mode in the applications menu?
Comment 15 Marinus Schraal 2016-07-06 09:32:17 UTC
That's the same idea, just not a gsetting. I think an application should not be working in low-discoverable modes.

Also my fear is that different views require more developer effort to keep up-to-date and it's easy to forget one while working on the other, thats why I'm not into this idea of multiple modes/views/whatever.
Comment 16 Marinus Schraal 2016-11-02 17:08:28 UTC
Added composer label to the album widget and composer search option.

Available in 3.23.1 .

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.