GNOME Bugzilla – Bug 734119
theme fixes/improvements
Last modified: 2015-06-12 16:50:37 UTC
the download bar lacks the top border, atm it's not possible to add it via css since it's made with a gtkbox which doesn't have borders (or anything else), I'd need a frame or some other cointainer inside it to be a ble to dd that missing border.
Created attachment 282591 [details] [review] Add downloads box to a frame I don't think we can put a frame inside the box, since we'd then need another box inside that frame to pack the download widgets into, and then there would be no point to having the first box. Would it be OK if we put the box inside a frame instead?
whatever giving me borders to style is ok
Does that patch work for you?
Review of attachment 282591 [details] [review]: Feel free to push this if Lapo confirms it works for him.
Created attachment 284617 [details] [review] Add custom style class to download box
Created attachment 285750 [details] [review] Increase spacing between download widgets I think you probably won't need this patch, but here is how you increase the horizontal spacing between the widgets that are packed into the downloads box.
Created attachment 285751 [details] [review] Increase margin around download widgets This sounds like more what you need, so that you can add margin between the widget and the edge of the downloads box. (The margin property sets margin-start, margin-end, margin-top, and margin-bottom all to the same value.)
Created attachment 286151 [details] [review] Theme fixes for Epiphany 3.14 Patch drop from Lapo! This patch breaks the incognito mode eye; we're waiting on a fix for that.
Lapo: I also have bug #735533 and bug #736364. I don't think we're going to merge anything until after 3.14, though, due to the tight time scale.
(In reply to comment #8) > Patch drop from Lapo! This patch breaks the incognito mode eye; we're waiting > on a fix for that. Lapo, any news here?
(In reply to comment #9) > Lapo: I also have bug #735533 and bug #736364. I don't think we're going to > merge anything until after 3.14, though, due to the tight time scale. I just filed bug #737688 which gets rid of the "active-menu" style class and replaces it with whatever is normal for menu buttons.
Do we still need this?
Comment on attachment 286151 [details] [review] Theme fixes for Epiphany 3.14 Yes, we still need this patch, but it's unfinished. Marking obsolete to get it off my personal list of patches. Hey Lapo, any news on this? In particular, the last patch you gave us replaced the eye image with a placeholder.
Moving this to the NEEDINFO state. Lapo, this is very close to missing 3.16 as well; if you have time to update it, that would be super.
Michael, this has been blocked by the privacy icon basically, we totally need one in adwaita icon theme in symbolic form, the eyebuster (I pretty much hate) could go there, Jakub can you take care of it, while I unfsck my build env?
Micheal, apart the fact that it's messy (it's a single diff which touches too much stuff) and the icon issue, what does it miss? I'm pretty short on time latelly unfortunatelly :-/
The only blocker I see is the icon!
Created attachment 304885 [details] [review] "privacy mode" icon
Comment on attachment 304885 [details] [review] "privacy mode" icon Attachment 304885 [details] pushed as 63dde2c - "privacy mode" icon
Thankyouverymuch! I never learned how to handle Sass, but I presume it will be chill to take Lapo's patch and s/document-open-symbolic/user-not-tracked-symbolic/
*** Bug 742088 has been marked as a duplicate of this bug. ***
*** Bug 724542 has been marked as a duplicate of this bug. ***
Created attachment 305096 [details] [review] Theme fixes for Epiphany 3.14
Michael, latest changes are in the wip/theme branch you nicelly created for me, try that out and merge if you think it's ok.
Claudio says this looks fine, so I am going to merge it. Thanks Lapo!