After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735533 - Remove totem-glow-button
Remove totem-glow-button
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 734119
 
 
Reported: 2014-08-27 16:24 UTC by Michael Catanzaro
Modified: 2015-06-12 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove totem-glow-button (9.24 KB, patch)
2014-08-27 16:24 UTC, Michael Catanzaro 		none Details | Review
Remove totem-glow-button (9.42 KB, patch)
2014-08-28 14:12 UTC, Michael Catanzaro 		none Details | Review
Remove totem-glow-button (10.13 KB, patch)
2015-06-11 19:10 UTC, Michael Catanzaro 		none Details | Review
Screenshot (373.62 KB, image/png)
2015-06-12 16:52 UTC, Michael Catanzaro 		  Details

Description Michael Catanzaro 2014-08-27 16:24:42 UTC 
This needs new CSS from lapo for it to work.
Comment 1 Michael Catanzaro 2014-08-27 16:24:44 UTC 
Created attachment 284622 [details] [review]
Remove totem-glow-button

We'll use the needs-attention style class instead
Comment 2 Lapo Calamandrei 2014-08-28 07:38:25 UTC 
doesn't build with the patch applied:

ephy-download-widget.c:31:31: fatal error: totem-glow-button.h: No such file or directory
 #include "totem-glow-button.h"
Comment 3 Michael Catanzaro 2014-08-28 14:12:04 UTC 
Created attachment 284697 [details] [review]
Remove totem-glow-button

We'll use the needs-attention style class instead
Comment 4 Carlos Garcia Campos 2015-02-03 11:53:11 UTC 
Review of attachment 284697 [details] [review]:

This looks good to me, but does it require a new GTK+ version for the needs-attention thing to work? or how does this work?
Comment 5 Michael Catanzaro 2015-02-03 14:48:53 UTC 
It needs to be committed at the same time as the unfinished patch in bug #734119. Note that the download box no longer glows -- it's changed to use a dot to indicate completion, like in a GtkStack -- which I'm not sure if I like or not, so it requires visual inspection. Lapo or I will post screenshots if the patch in bug #734119 is ever finished.
Comment 6 Michael Catanzaro 2015-06-11 19:10:00 UTC 
Created attachment 305097 [details] [review]
Remove totem-glow-button

We'll use the needs-attention style class instead
Comment 7 Michael Catanzaro 2015-06-12 16:52:59 UTC 
Created attachment 305167 [details]
Screenshot

Screenshot when combined with Lapo's theme work; a blue circle indicator replaces the pulsing gray "color"