GNOME Bugzilla – Bug 724542
The incognito mode with dark theme look very bad
Last modified: 2015-06-09 19:18:16 UTC
Created attachment 269391 [details] Screenshot See the screenshot.
Created attachment 304738 [details] [review] removes incognito background colours Because the incognito window has a static light background, themes with light text and icons don't work well with it. This patch removes the custom background colours, so the default background is used. The background image indicating incognito mode still remains, but it might not look good with all themes because of its static colour.
Created attachment 304741 [details] result of removing incognito background colours
Can you post a screenshot of how it appears in the light theme, please?
Created attachment 304742 [details] light theme
Well this patch basically removes the existing incognito mode theme, which I am personally OK with, though maybe someone else will complain. Frankly, the theme didn't work particularly well even with the light theme, not to mention all the trouble it's caused for users of other themes. The eye is still problematic, as you've noted. I wish we had a symbolic version of the eye that we could color in the CSS. Looking over the patch in bug #734119, I think it might address this issue as well; it looks like it picks colors based on your theme colors. Maybe we could use that instead, if it did not also ruin that stupid eye!
I think we need Jakub here; maybe it's possible to fix the dark theme by having a new variant (in particular of the eye). For users of other themes I wouldn't bother.
Thanks for your contribution. Let's consider this as an alternative solution to bug #734119. *** This bug has been marked as a duplicate of bug 734119 ***