After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737688 - Use a GtkMenuButton for the window menu and remove EphyPageMenuAction
Use a GtkMenuButton for the window menu and remove EphyPageMenuAction
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 734119
 
 
Reported: 2014-09-30 22:56 UTC by Michael Catanzaro
Modified: 2014-10-01 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use a GtkMenuButton for the window menu and remove EphyPageMenuAction (13.21 KB, patch)
2014-09-30 22:56 UTC, Michael Catanzaro
none Details | Review
Use a GtkMenuButton for the window menu and remove EphyPageMenuAction (13.21 KB, patch)
2014-09-30 23:00 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-09-30 22:56:04 UTC
I guess EphyPageMenuAction was the prototype for GtkMenuButtons. We don't seem to need it anymore and it's causing style bugs.
Comment 1 Michael Catanzaro 2014-09-30 22:56:06 UTC
Created attachment 287488 [details] [review]
Use a GtkMenuButton for the window menu and remove EphyPageMenuAction

This fixes the style of the button when it is active with GTK+ 3.14.
Comment 2 Michael Catanzaro 2014-09-30 23:00:51 UTC
Created attachment 287489 [details] [review]
Use a GtkMenuButton for the window menu and remove EphyPageMenuAction

Fix indentation mistake
Comment 3 Michael Catanzaro 2014-10-01 14:53:04 UTC
Attachment 287489 [details] pushed as fd4357f - Use a GtkMenuButton for the window menu and remove EphyPageMenuAction