After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 714554 - Always show images
Always show images
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: conversations
master
Other All
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
: 733743 (view as bug list)
Depends on: 768263
Blocks:
 
 
Reported: 2013-03-10 04:34 UTC by Geary Maintainers
Modified: 2019-03-17 04:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (9.22 KB, patch)
2016-01-18 18:44 UTC, Ralph Plawetzki
none Details | Review

Description Charles Lindsay 2013-11-21 20:28:29 UTC


---- Reported by geary-maint@gnome.bugs 2013-03-10 09:34:00 -0700 ----

Original Redmine bug id: 6507
Original URL: http://redmine.yorba.org/issues/6507
Searchable id: yorba-bug-6507
Original author: Nil Gradisnik
Original description:

It would be very useful to me and probably to many other users if there was an
option to always show images in emails.

Maybe just a simple checkbox.

Or something similar like in Evolution Mail settings:

Related issues:
related to geary - Feature #5642: Allow external images from a particular
sender to always ... (Fixed)
related to geary - Feature #5683: remember that a messages's images have been
shown (Fixed)
duplicated by geary - Feature #6664: Add option to always load remote images
by default (Duplicate)



---- Additional Comments From geary-maint@gnome.bugs 2013-05-15 14:46:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 9 months ago

  * **Category** changed from _client_ to _conversations_
  * **Target version** set to _0.4.0_

####

#2

Updated by Eric Gregory 9 months ago

If we do this we should be smart about it. At a minimum, we should check URLs
against a list of known attack sites, and never load images for messages in
the Spam folder.

####

#3

Updated by Jim Nelson 6 months ago

  * **Target version** changed from _0.4.0_ to _0.5.0_

We've nailed down the other "show images" tickets, I think this one will have
to wait for 0.5, especially since there's some trepidation about simply
showing any image regardless of origin.



--- Bug imported by chaz@yorba.org 2013-11-21 20:28 UTC  ---

This bug was previously known as _bug_ 6507 at http://redmine.yorba.org/show_bug.cgi?id=6507

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Silvio Giuliano 2013-12-14 03:20:18 UTC
Hello everything, I think maybe for the security issue could be a useful option, in the bar above to open email message, "Always trust considers this sender" put under "show images" in the settings and maybe the voice " allowed senders "with the possibility 'to add and remove them. For the more "arrogant", I thought to add, as always tick box in the options, an item such as "always show pictures" with a message "this operation and 'risky, could compromise your security, are you sure?" . I hope that my idea is useful for your software. :) Good job everyone!
Comment 2 Jim Nelson 2014-07-25 19:54:39 UTC
*** Bug 733743 has been marked as a duplicate of this bug. ***
Comment 3 Johny Why 2015-05-24 20:41:52 UTC
hi

PLEASE PLEASE PLEASE add option to display all images for all senders by default.

it is EXTREMELY ANNOYING AND INCONVENIENT to click 'show images' for every sender.

i trust my senders. i get almost no junk mail, thx to spam filters. i do not need this block.

"there's some trepidation about simply showing any image regardless of origin."

-- USER CHOICE! USER FREEDOM! MY RISK!

P L E A S E !!!!!

thx
Comment 4 Johny Why 2015-05-24 20:44:29 UTC
i see duplicate bug 714794, but i cannot tell if these were merged or what, so i am posting to both.

sorry for all caps but this is a biggie for me.
Comment 5 Johny Why 2015-05-24 20:47:14 UTC
the rare junk mail i do get does not contain offensive or NTFW images anyway. i don't visit or give my email address to porn/violence/fraudulent websites.

do no need this block.
Comment 6 Jim Nelson 2015-05-24 22:09:06 UTC
> -- USER CHOICE! USER FREEDOM! MY RISK!

What about developer choice, developer freedom, developer risk?

* Choice?  Because, like everyone else on this planet, we have limited time and resources.  We have to prioritize things in life and on this project.

* Freedom?  Freedom to choose what we want to focus on.  Freedom to scratch our own itches.

* Risk?  Introducing this "small" or "simple" change can introduce bugs elsewhere in the code.  Who gets to fix those new bugs?  Why, the developers.

Another risk: even though loading images may not be a perceived issue for you, if some other user out there clicks on that checkbox without considering all the issues, they may be leaking important private information to malicious third-parties -- all for your convenience.

This bug is open.  That means we're not opposed to adding it to Geary.  But it has to be done right.

The absolute best way to get your itches scratched is to jump in and help out.  Posting all-caps pleas on a bug does not advance the feature.

If this is so important to you, do what you're begging the developers to do: dedicate your own valuable time to solving this problem.
Comment 7 Johny Why 2015-05-24 22:42:29 UTC
i'm VERY GRATEFUL for the efforts of the developers. 

in fact, the ONLY reason i switched to gnome was to use GEARY. 

i actually attempted to install Vala on my last distro, just so i could compile Geary. no success on that yet. it will be a long while before i have the skills/knowledge to do any geary dev. 

thx
Comment 8 Johny Why 2015-05-24 22:43:44 UTC
this sounds good:

"Eric Gregory 9 months ago

If we do this we should be smart about it. At a minimum, we should check URLs
against a list of known attack sites, and never load images for messages in
the Spam folder."
Comment 9 Johny Why 2015-05-25 01:44:17 UTC
Thank you very much to the team that built geary. It is the fastest, most beautiful desktop email client i've ever seen. I have been searching for a simple, beautiful, fast linux client. Finally found it! No other comes close.
Comment 10 Evgeny Kolesnikov 2015-07-17 06:17:16 UTC
Don't know if I should create new bug with this, but anyway, there are people (like me) who never ever wanted to load any of the remote images.

It's not so annoying as for opposite (images aren't loaded by default), but still the yellow inline dialog wastes space in every message (and distracts a little too).

Just for consideration, whenever you will be challenging this topic, don't forget about "never show remote images". 

Maybe, the whole problem deserves option in preferences, like

Show remote images: (*) Ask    ( ) Never   ( ) Always

And thanks for the Geary.
Comment 11 Johny Why 2015-07-17 17:43:58 UTC
+1, this is best:

option in preferences, like

Show remote images: (*) Ask    ( ) Never   ( ) Always
Comment 12 Ralph Plawetzki 2016-01-18 18:44:29 UTC
Created attachment 319288 [details] [review]
Patch

I prepared a patch that addresses the issue.
It contains the following features (+) or not (-):
+ a new configuration option that enables images in all emails
+ except for emails in SPAM folder (for security reasons)
+ the former mechanism with the two buttons to show images for a specific email or for all email from an address is kept and all the settings according to this features are kept as well (the new configuration option overrides these when activated)
- there is no new URL checking implemented with this change
- no option to get rid of the yellow box to show images for a specific email or for all email from an address

The code is written against trunk and tested.
Comment 13 Michael Gratton 2016-04-12 07:39:16 UTC
I'm inclined to think that this should happen without any preference needed, but only for people in your EDS/libfolks address book.

This would mean implementing Bug 714696 and/or Bug 714160, but also providing a way to add senders those sources by a user action ("Add to Addressbook" in popover menu on sender email address) and maybe even via "Always Show Images".

I'd happily accept patches to these ends.
Comment 14 Johny Why 2016-04-12 17:27:36 UTC
"this should happen without any preference needed, but only for people in your EDS/libfolks address book."

Myself, the OP, and others would like to always show images from ALL senders. Not just people in the address boo .
Comment 15 Johny Why 2016-04-12 18:02:37 UTC
"there's some trepidation about simply showing any image regardless of origin."

User preference, please. 

I do not receive porno mail, because I don't use porno sites. My spam filters keep most spam out of my inbox. I do not have trepidation. 

No need to block images from senders who've been previously marked as spam, because they won't appear in the inbox anyway.
Comment 16 Johny Why 2016-04-12 18:07:15 UTC
> would like to always show images from ALL
> senders. Not just people in the address book. 

It's fine if that's off by default, and requires enabling with a switch in preferences.
Comment 17 Michael Gratton 2016-04-13 00:34:30 UTC
Hi Johny, Thanks for the input, I'll keep your argument in mind when reviewing patches for this in the future.
Comment 18 Johny Why 2016-04-13 01:33:41 UTC
(In reply to Michael Gratton from comment #17)
> Hi Johny, Thanks for the input, I'll keep your argument in mind when
> reviewing patches for this in the future.

thx

"this should happen without any preference needed, but only for people in your EDS/libfolks address book."

i agree, if they are in my address book, then trust them automatically. 

But, don't make me put someone in my address book as a 'workaround' to show images. I don't need every darned newsletter i'm subscribed to in my address book. 

The whole point of the OP is a *global* setting-- we're tired of clicking 'show images' for every email, or even for every sender. 

Scary images are not a problem for *everyone*. 

thx.
Comment 19 Jeroni Brunet 2016-06-03 15:53:28 UTC
Hi all,

I did a trick over sqlite3 database:

- Navige to ~/.local/share/geary/[email address]/
- Open geary.db with sqlitebrowser
- Select "ContactTable" and "Modify Table".
- Put ALWAYSLOADREMOTEIMAGES as default value in "flags" column (press OK twice)
- Select "Execute SQL" and write in the first box:
      UPDATE ContactTable SET flags='ALWAYSLOADREMOTEIMAGES';
  Ctrl + e to execute this command
- Write changes
- Restart geary

It has to be done for every email account. Good Luck!
Comment 20 jeremy9856 2016-07-20 09:10:18 UTC
It will be great if we have the choice to always display images. I think thunderbird, and others mail clients, have this feature.

Thanks !
Comment 21 Michael Gratton 2017-05-19 03:28:19 UTC
Bug 782456 was just filed, requesting the opposite of this - always deny remote image loading by default. Since there is some demand from users either way, making a hidden pref for setting the remote image loading policy that allows the user to choose one of {always, ask, never} might be worthwhile.

However, since we have a duty of care to our users, we want to reduce the harm inflicted on people who might hear about this pref in say an online forum and set it to "always" for the convenience, without realising they are selling themselves down the river to spammers and malware authors.

As such, a prerequisite for implementing such a pref for this bug is to at least to have implemented sealing messages in the junk folder first, i.e. Bug 768263, so that even when the pref is set to "always", messages in the Junk folder are treated as described in that bug. That way people who don't realise the ramifications of setting this pref to "always" are at least protected when viewing their junk folder.

I also just filed Bug 782815 to cover always loading images for contacts in EDS and online accounts, per comment #13, which should still be doable regardless of all this.
Comment 22 Michael Gratton 2019-03-17 04:33:02 UTC
Closing this in favour of https://gitlab.gnome.org/GNOME/geary/issues/319