Created attachment 240267 [details] [review]
status/keyboard: Switch input source on special modifiers accelerator

This simply mimics the X server's layout switching behavior by
advancing to the next input source and wrapping around.

*** Bug 689839 has been marked as a duplicate of this bug. ***

*** Bug 696685 has been marked as a duplicate of this bug. ***

*** Bug 693858 has been marked as a duplicate of this bug. ***

*** Bug 697161 has been marked as a duplicate of this bug. ***

*** Bug 698543 has been marked as a duplicate of this bug. ***

You patch breaks gnome-shell 3.8.1 =(

This is not a standalone patch - there are dependencies on other shell, mutter and gsd patches from different bug reports. I've tested the set only yesterday, and there is it does certainly not break gnome-shell, so I reckon you missed some patches. The plan is to have this working in 3.8.2 which is due in about two weeks, so the easiest approach for you would be to show some patience.

(In reply to comment #8)
> This is not a standalone patch - there are dependencies on other shell, mutter
> and gsd patches from different bug reports. I've tested the set only yesterday,
> and there is it does certainly not break gnome-shell, so I reckon you missed
> some patches. The plan is to have this working in 3.8.2 which is due in about
> two weeks, so the easiest approach for you would be to show some patience.
Florian, thx.

Created attachment 243784 [details] [review]
status/keyboard: Switch input source on special modifiers accelerator

--

Of course, I forgot to update the signal handler after
https://bugzilla.gnome.org/show_bug.cgi?id=697002#c12

Review of attachment 243784 [details] [review]:

LGTM

(In reply to comment #8)
> This is not a standalone patch - there are dependencies on other shell, mutter
> and gsd patches from different bug reports. I've tested the set only yesterday,
> and there is it does certainly not break gnome-shell, so I reckon you missed
> some patches. The plan is to have this working in 3.8.2 which is due in about
> two weeks, so the easiest approach for you would be to show some patience.
In 3.8.2 not fixed. In overview modifiers-only not change language.

(In reply to comment #12)
> In 3.8.2 not fixed. In overview modifiers-only not change language.

Thanks, but if we thought the bug *was* fixed, the report's status would have been changed to RESOLVED FIXED. It's not a trivial issue which involves patches to gnome-settings-daemon, mutter, gnome-shell and gnome-control-center. All patches for the former three modules are ready to land, but the latter is still missing, so we decided to postpone the whole set to a later release - otherwise we'd end up with a UI to set modifier-only shortcuts that does nothing and modifiers-only shortcuts that need to be set from the command line (e.g. for most users, those shortcuts wouldn't work in any case, not "only" inside the overview).
We are aware that this is a major limitations for users of multiple keyboard layouts, but leaving snarky comments on bugzilla won't speed up fixing anything.

Hi Florian,

Should we wait for the next major release (3.10.*) or minor (3.8.3). Or the progress timeline is unknown yet? I wonder because the bug is pretty annoying.

There are no more officially scheduled 3.8.x releases, but we are indeed planning to roll a 3.8.3 release with these changes once everything is ready.

(In reply to comment #15)
> There are no more officially scheduled 3.8.x releases, but we are indeed
> planning to roll a 3.8.3 release with these changes once everything is ready.
Thx for the answers. Believe!

*** Bug 700325 has been marked as a duplicate of this bug. ***

Attachment 243784 [details] pushed as d45ab6f - status/keyboard: Switch input source on special modifiers accelerator

Hm. I have built today last snapshot of gnome-shell and apply all patches on g-s-d and mutter. Yes, Win+Space switch layout in message tray (chat window), but modifier-only switch stop working everywhere.

Maybe I must patch something else? Please test 'modifier-only switch' before release again.

(In reply to comment #19)
> Hm. I have built today last snapshot of gnome-shell and apply all patches on
> g-s-d and mutter.

Which branch? The necessary patches have landed on the gnome-3-8 branches of g-s-d, g-c-c, mutter and g-s, but not yet on master (not a fan of that, but I trust Rui will get to it) ...

Everything is on master already.

Arkady, you also need the gnome-3-8 branch of g-c-c and then set the shortcut there.

Thanks, Rui, I will build g-c-c also, test it and write here the result.

(In reply to comment #21)
> Everything is on master already.

Ah, great! It wasn't when I checked a couple of hours ago :-)

Work only once with latest Fedora 19 update: 
* switch to message tray
* press super+space - layout switched
* press super+space again - layout doesn't switch

For me it works fine. Win+Space and other modifiers.

(In reply to comment #24)
> Work only once with latest Fedora 19 update: 

None of these patches are in any versions of Fedora yet (either 19 or rawhide).

I've built last snapshots here: http://koji.russianfedora.pro/koji/ for F19.

I have update for a few hours ago and the layout can switch in message tray(g-c-c+g-s-d+gnome-shell+mutter, all of version 3.8.3). Moreover, now it can switch every time(super+space any times I want). I'll try to find the case where it doesn't work or, maybe, wait for new patches to test

(In reply to comment #28)
> I have update for a few hours ago and the layout can switch in message
> tray(g-c-c+g-s-d+gnome-shell+mutter, all of version 3.8.3).

Not sure where you got those versions from, but none of those modules actually have had a 3.8.3 release yet - latest (stable) upstream version is 3.8.2 for all of them.

Found the case:
* close all apps(you should see the clear desktop)
* press super + M
* press super + space(layout switched)
* press super + space(nothing happened)

I'm using Russian Fedora 19. Maybe, it is this distro-specific versions. I don't know

Yes, I confirm Alexey report.

Florian I think that 3.8.3 packages what Alexey use are my builded last snapshots (link below) from gnome-3-8 branch.

Mmh, I can reproduce this now>

(In reply to comment #30)
> Found the case:
> * close all apps(you should see the clear desktop)

Or just switch to an empty workspace.
> * press super + M

Or super to go to the overview. Or alt-f2. Or ...

> * press super + space(layout switched)
> * press super + space(nothing happened)

This affects *all* shortcuts - the keyboard stops working entirely.

Please file a new bug report for this.

The issue reported in comment 30 has been fixed now. See bug 701219.