After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697009 - status/keyboard: Allow switching input source in the message tray
status/keyboard: Allow switching input source in the message tray
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 697023 697448 697963 698882 (view as bug list)
Depends on: 697008
Blocks:
 
 
Reported: 2013-03-31 22:46 UTC by Rui Matos
Modified: 2013-05-24 22:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
status/keyboard: Allow switching input source in the message tray (2.78 KB, patch)
2013-03-31 22:46 UTC, Rui Matos 		reviewed Details | Review
status/keyboard: Allow switching input source in the message tray (2.86 KB, patch)
2013-05-13 21:00 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-03-31 22:46:33 UTC 
.
Comment 1 Rui Matos 2013-03-31 22:46:36 UTC 
Created attachment 240268 [details] [review]
status/keyboard: Allow switching input source in the message tray

We still can't show a popup switcher in the message tray but we can at
least degrade gracefully and advance to the next input source.
Comment 2 Florian Müllner 2013-04-01 10:08:05 UTC 
*** Bug 697023 has been marked as a duplicate of this bug. ***
Comment 3 Rui Matos 2013-04-06 19:48:32 UTC 
*** Bug 697448 has been marked as a duplicate of this bug. ***
Comment 4 Rui Matos 2013-04-13 20:01:02 UTC 
*** Bug 697963 has been marked as a duplicate of this bug. ***
Comment 5 Rui Matos 2013-04-25 21:15:04 UTC 
*** Bug 698882 has been marked as a duplicate of this bug. ***
Comment 6 Florian Müllner 2013-05-13 13:47:05 UTC 
Review of attachment 240268 [details] [review]:

Looks good, but we need the same for open top bar menus.

::: js/ui/status/keyboard.js
@@ +471,3 @@
+        // pushModal/popModal and grabHelper. See
+        // https://bugzilla.gnome.org/show_bug.cgi?id=695143 .
+        if (Main.keybindingMode == Shell.KeyBindingMode.MESSAGE_TRAY) {

|| Main.keybindingMode == Shell.KeyBindingMode.TOPBAR_POPUP
Comment 7 Rui Matos 2013-05-13 21:00:50 UTC 
Created attachment 244108 [details] [review]
status/keyboard: Allow switching input source in the message tray

--

(In reply to comment #6)
> Looks good, but we need the same for open top bar menus.
>
> ::: js/ui/status/keyboard.js
> @@ +471,3 @@
> +        // pushModal/popModal and grabHelper. See
> +        // https://bugzilla.gnome.org/show_bug.cgi?id=695143 .
> +        if (Main.keybindingMode == Shell.KeyBindingMode.MESSAGE_TRAY) {
>
> || Main.keybindingMode == Shell.KeyBindingMode.TOPBAR_POPUP

Right!
Comment 8 Florian Müllner 2013-05-13 21:23:49 UTC 
Review of attachment 244108 [details] [review]:

Yup
Comment 9 Rui Matos 2013-05-24 22:20:03 UTC 
Attachment 244108 [details] pushed as 3ce2056 - status/keyboard: Allow switching input source in the message tray