After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 398093 - Album art: decouple art widget from artdb search
Album art: decouple art widget from artdb search
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.9.7
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 363694 398102 398231 398384
 
 
Reported: 2007-01-18 18:13 UTC by Ed Catmur
Modified: 2007-01-21 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
art-widget-decouple.patch (9.28 KB, patch)
2007-01-18 18:35 UTC, Ed Catmur 		none Details | Review
20art-widget-decouple.patch (8.64 KB, patch)
2007-01-19 01:41 UTC, Ed Catmur 		none Details | Review
20art-widget-decouple.patch (8.57 KB, patch)
2007-01-19 01:48 UTC, Ed Catmur 		none Details | Review
20art-widget-decouple.patch (8.89 KB, patch)
2007-01-19 02:15 UTC, Ed Catmur 		none Details | Review
20art-widget-decouple.patch (8.89 KB, patch)
2007-01-19 14:00 UTC, Ed Catmur 		committed Details | Review

Description Ed Catmur 2007-01-18 18:13:34 UTC 
Currently the art widget (in bottom left) is created in and passed art from the database search in the ArtDisplayPlugin class.

This is bad; it should be its own widget and should receive art over the metadatabus like other consumers.  

The ArtDisplayPlugin class should create the widget as an ArtDisplayWidget and just handle calling CoverArtDatabase.get_pixbuf and passing the results out over the metadatabus.

This will allow other sources of album art to have their results shown in the art widget without going via CoverArtDatabase.
Comment 1 Ed Catmur 2007-01-18 18:35:51 UTC 
Created attachment 80623 [details] [review]
art-widget-decouple.patch

Decouples stuff as above.

Also allows passing uris back from database search (future).
Comment 2 Ed Catmur 2007-01-19 01:41:40 UTC 
Created attachment 80669 [details] [review]
20art-widget-decouple.patch

Actually, it's better to have the plugin proxy for the widget.  This still allows a level of separation, though.
Comment 3 Ed Catmur 2007-01-19 01:48:35 UTC 
Created attachment 80670 [details] [review]
20art-widget-decouple.patch

rm some crud
Comment 4 Ed Catmur 2007-01-19 02:15:07 UTC 
Created attachment 80672 [details] [review]
20art-widget-decouple.patch

Disconnect 'entry-extra-metadata-notify::rb:coverArt' handler as required.
Comment 5 Ed Catmur 2007-01-19 14:00:12 UTC 
Created attachment 80695 [details] [review]
20art-widget-decouple.patch

Fix thinko in saving image to cache
Comment 6 James "Doc" Livingston 2007-01-21 07:13:59 UTC 
Committed to svn. Thanks.