After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 398102 - Album art: Art database should allow setting (and saving) covers
Album art: Art database should allow setting (and saving) covers
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.9.7
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 398093
Blocks: 363694
 
 
Reported: 2007-01-18 18:44 UTC by Ed Catmur
Modified: 2007-01-21 07:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cover-art-db-allow-setting.patch (901 bytes, patch)
2007-01-18 18:46 UTC, Ed Catmur 		none Details | Review
cover-art-db-allow-setting.patch (3.24 KB, patch)
2007-01-18 19:26 UTC, Ed Catmur 		none Details | Review
cover-art-db-allow-setting.patch (3.39 KB, patch)
2007-01-18 19:39 UTC, Ed Catmur 		none Details | Review
cover-art-db-allow-setting.patch (4.47 KB, patch)
2007-01-18 23:08 UTC, Ed Catmur 		none Details | Review
25cover-art-db-allow-setting.patch (4.47 KB, patch)
2007-01-20 13:27 UTC, Ed Catmur 		committed Details | Review

Description Ed Catmur 2007-01-18 18:44:40 UTC 
The art database should allow setting and saving of covers.  This is needed for e.g. DND.
Comment 1 Ed Catmur 2007-01-18 18:46:32 UTC 
Created attachment 80628 [details] [review]
cover-art-db-allow-setting.patch

Preliminary patch; saves to cache in .gnome2/rhythmbox.  More needed.
Comment 2 Ed Catmur 2007-01-18 19:26:52 UTC 
Created attachment 80633 [details] [review]
cover-art-db-allow-setting.patch

Save locally to album folder (to "Cover.jpg"); conservative/pessimistic algorithm ensures this is only done when correct (if the only files in the directory are image files and audio files in db with same artist+album).
Comment 3 Ed Catmur 2007-01-18 19:39:12 UTC 
Created attachment 80636 [details] [review]
cover-art-db-allow-setting.patch

Emulate rb_canonicalise_uri to ensure db.entry_lookup_by_location works.
Comment 4 Ed Catmur 2007-01-18 23:08:12 UTC 
Created attachment 80658 [details] [review]
cover-art-db-allow-setting.patch

some fixes
Comment 5 Ed Catmur 2007-01-20 13:27:46 UTC 
Created attachment 80755 [details] [review]
25cover-art-db-allow-setting.patch

Get saving to actually work.  Properly tested this time.  (Honest!)
Comment 6 James "Doc" Livingston 2007-01-21 07:16:12 UTC 
Committed to svn, thanks.