After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339156 - string "Read" needs gettext context
string "Read" needs gettext context
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.8.x (obsolete)
Other Linux
: Normal trivial
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2006-04-20 10:58 UTC by André Klapper
Modified: 2013-09-10 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch(TM). (6.35 KB, patch)
2006-07-17 22:42 UTC, André Klapper
none Details | Review
patch² (6.30 KB, patch)
2006-07-18 10:13 UTC, André Klapper
needs-work Details | Review
screenshot in glade-2 (38.71 KB, image/png)
2008-01-25 02:06 UTC, André Klapper
  Details
patch (4.04 KB, patch)
2008-01-25 02:13 UTC, André Klapper
committed Details | Review

Description André Klapper 2006-04-20 10:58:32 UTC
#: ../mail/em-filter-i18n.h:47 ../mail/message-tag-followup.c:81
msgid "Read"

needs translator comments. this can both mean "to read" as well as "has been read" which are quite different in other languages.
obviously it's the second meaning.
Comment 1 André Klapper 2006-04-20 10:59:45 UTC
this is currently wrong in the french version because of that (must be "lu", but currently it's "lire"), see bug 339097.
Comment 2 André Klapper 2006-04-20 11:01:06 UTC
and in
#: ../ui/evolution-mail-message.xml.h:126
msgid "_Read"

...this is bug 339097, to be correct.
Comment 3 André Klapper 2006-04-20 19:17:25 UTC
i have to correct myself:
adding translator comments does not help, we need gettext context, like in bug 328988.

...but is this possible for glade and xml files? i don't know at all. :-/

#: ../plugins/groupwise-features/proxy-add-dialog.glade.h:13
#: ../ui/evolution-mail-message.xml.h:126
msgid "_Read"

#: ../plugins/groupwise-features/proxy-add-dialog.glade.h:13
is about the permissions, you can choose "Read" and "Write". so "read" means "to read".
this would be in german "Lesen" or in french "Lire".
#: ../ui/evolution-mail-message.xml.h:126
is about marking a message as read. so "read" means "has been read".
this would be in german "Gelesen" or in french "Lu".

currently one CANNOT translate this correctly, as it has two different meanings.
Comment 4 André Klapper 2006-04-20 19:23:40 UTC
james, can one add gettext context to xml/glade files? any ideas how to fix this? :-/
Comment 5 Danilo Segan 2006-07-15 20:17:59 UTC
Adding context to one of the message occurences is enough. So if we can add context to glade message that would do it (we'd still want a comment on both, though).
Comment 6 André Klapper 2006-07-17 22:42:23 UTC
Created attachment 69076 [details] [review]
patch(TM).

hvala danilo - attaching a patch as proposed.
Comment 7 André Klapper 2006-07-18 10:13:57 UTC
Created attachment 69098 [details] [review]
patch²

corrected
Comment 8 André Klapper 2006-07-18 10:24:32 UTC
hmm. obviously that translated part does not get stripped in the UI, at least when i open the glade file in glade-2. :-(
any ideas anyone? i did use context="yes".
Comment 9 Danilo Segan 2006-07-20 07:22:01 UTC
Translation must not contain the "...|" part. That is a limitation of our API. (if I understood the problem you're having)
Comment 10 Srinivasa Ragavan 2007-08-23 09:23:21 UTC
From comment #8, marking the patch as needs-work
Comment 11 André Klapper 2008-01-25 02:06:56 UTC
Created attachment 103692 [details]
screenshot in glade-2

danilo:
if i edit plugins/groupwise-features/proxy-add-dialog.glade and change
  <property name="label" translatable="yes">_Read</property>
to
  <property name="label" translatable="yes" context="yes" comments="Translators: strip the part in front of the |">permission to read|_Read</property>
and open the glade file in glade-2, the context is not stripped in the UI. see screenshot.
i can't test this in real as i don't have a groupwise account to test.
Comment 12 André Klapper 2008-01-25 02:13:47 UTC
Created attachment 103693 [details] [review]
patch

updated patch. someone with groupwise access should test this. as long as nobody offers me groupwise access i cannot test this (and will not translate any groupwise-related stuff in the user manual), right? right.
Comment 13 Srinivasa Ragavan 2008-01-28 04:37:26 UTC
Andre, I tested it and looks fine to me. 
Comment 14 Suman Manjunath 2008-01-28 05:47:14 UTC
Patch committed to SVN trunk as r34910
(http://svn.gnome.org/viewvc/evolution?view=revision&revision=34910)
Comment 15 Matthew Barnes 2008-03-11 00:29:12 UTC
Bumping version to a stable release.