Would you care to clarify which dialogs and point to which section of the HIG you're referencing?  Also, please specify a version.

Nearly all of them. CVS HEAD.

GtkDialog:s need:
5px border
2px spacing in ->vbox
5px border for ->vbox
for a total of 12px borders.

tables should be 12px intercol, 6px inter-row.
Indentation should be 12px.
12 px between label and associated component (e.g. label + entry).

HIG chapter 8, sect. 2.2.

I'm going to attach a patch for the glade files in libseahorse; I started on src/*glade too but gave up when I reached seahorse-ssh-key-properties.glade which mimicks a GtkDialog but actually is a window (it's harder to adjust spacings in this case).

Created attachment 60174 [details] [review]
patch for libseahorse/*glade

Created attachment 60176 [details] [review]
patch for src/*glade

except seahorse-generate-druid.glade, seahorse-key-manager.glade, seahorse-key-properties.glade, seahorse-pgp-public-key-properties.glade, and seahorse-ssh-key-properties.glade where I wasn't sure about how to fix it.


Also removed the separator where it was still present.

Thanks. That's wonderful. I'll check this over and should commit shortly. 

I'm interested as to where the 5px + 5px + 2px comes from... 

It's a common technique used in gnome-panel, gnome-applets, gnome-utils, nautilus, and many more GNOME modules, see for example bug 171026 bug 171165 bug 171168 bug 171172 bug 171274 bug 171293 bug  171298 bug 171317 bug 171319 bug 172667 bug 309058 bug 319028.

Makes sense. Committed.

seahorse-generate-druid.glade, seahorse-key-manager.glade,
seahorse-key-properties.glade, seahorse-pgp-public-key-properties.glade, and
seahorse-ssh-key-properties.glade still need to be fixed... new bug or reopen?

Reopening for the remaining glade files.

Was there a reason that seahorse-pgp-public-key-properties etc. are a GtkWindow not a GtkDialog yet look like a dialogue? Changing that to dialogue would simplify the HIGification, but probably require a few tiny code changes somewhere, not just glade changes.

Don't remember the reason. But if you make the glade changes I'll make the code changes. 

Created attachment 61645 [details] [review]
next patch

This makes *key-properties.glade GtkDialog instead of GtkWindow, and changes the C code accordingly; I hope it's correct :)
This is just the minimal change to make those GtkDialog, there's more HIGification to do, but I postponed that as to make it easier to verify that this doesn't introduce new bugs.

Looks good. Committed. Thanks.

BTW, seahorse-key-properties.glade (ie: the dialog for PGP private keys) is going to get an overhaul shortly (to remove unapplicable controls and the like), so I'd skip that one if I were you.

The other two dialogs (seahorse-pgp-public-key-properties.glade and seahorse-ssh-key-properties.glade) have been recently redone. If you have a chance to list here the various HIG booboos we've made on those two, then we can make sure that seahorse-key-properties.glade is up to snuff when it's redone.

Created attachment 61688 [details] [review]
changes for seahorse-pgp-public-key-properties.glade

It was already rather good actutally :)
I noticed only minor things: using 3 instead of 6 as inter-row spacing in GtkTable, using 24 instead of 12 px left padding in one GtkAlignment.
I increased the horizontal spacing between the big icons and their text to 12px (like it's in a message dialogue).

Does the 'placeholder' text ever get used? I think those labels should just be empty by default (it adds unnecessary work for pango to first parse the placeholder string and then again the real string when it's set). Anyway, I marked those texts as not translatable, so at least translators don't waste time :)

One bit that most poeple probably wouldn't care about is that using a frameless GtkFrame instead of vbox with label + alignments adds 1 px at the right, so things don't line up perfectly... I changed those, but as I said, others probably wouldn't care :)

Committed. The current mockup of the private key dialog doesn't have these fixes yet (see #335414) but I'll fix them before it goes into CVS.

Closing this bug. Thanks for the help. If you see any additional HIG changes needed, please file further bugs.