GNOME Bugzilla – Bug 171026
HIG Fixes
Last modified: 2012-01-31 23:20:12 UTC
Version details: 2. I am attaching a patch to correct the following HIG issues. 1. Libgames-support HIG changes: * Update games-frame.[ch] to latest gimpframes.[ch] - This makes the games-frame widget HIG compliant See: http://developer.gimp.org/api/2.0/libgimpwidgets/GimpFrame.html 2. BlackJack Preferences dialog changes: * Use GNOME HIG recommended dialog padding - 12 pixels of padding around dialog border - 12 pixels between action area and vbox - 18 pixels of padding between frames * Add missing mnemonics to Gtk Check Button labels * Add missing mnemonic to Gtk Button label * Use Header capitalization for Gtk Button label See: http://developer.gnome.org/projects/gup/hig/2.0/design-text-labels.html#layout-capitalization 3. Other BlackJack HIG changes: * Add missing mnemonics to menu labels * Capitalize the application name so it is displayed capitalized in the about dialog * Replace ":" with " - " in window title See: http://developer.gnome.org/projects/gup/hig/2.0/windows-primary.html#primary-window-titles
Created attachment 38972 [details] [review] The proposed blackjack patch.
Created attachment 38973 [details] [review] The proposed libgames-support patch.
Created attachment 38974 [details] Screenshot of Blackjack Preferece Dialog (Before) The 'Games', 'Rules' and 'Card Style' strings are not left aligned. Notice the incorrect alignment of the various widgets on the right side of the dialog.
Created attachment 38975 [details] Screenshot of Blackjack Preferece Dialog (After)
Created attachment 38981 [details] [review] The proposed blackjack patch. This updated patch also fixes the bad resizing behavior of the old preference dialog.
Generally looks good. Two comments: - For the gimp-frame code, could you make it use the G_DEFINE_TYPE macro (or one of that family). Obviously this isn't essential, but it makes the code cleaner (unfortunately only a few of the libgames-support widgets use it so far). - "Toolbar" should not be changed to "Show Toolbar", most other apps have just "Toolbar" and I would like to be consistent.
Created attachment 38985 [details] [review] Updated blackjack patch. This patch changes "Show Toolbar" back to "Toolbar".
Callum, I am unfamiliar with the G_DEFINE_TYPE macro, so I don't know what is required to make it use that macro.
Look at: http://developer.gnome.org/doc/API/2.0/gobject/gobject-Type-Information.html#G-DEFINE-TYPE:CAPS and games-card-images.c. It replaces a lot of the boiler-plate code with a single macro. Essentially you can replace the games_frame_get_type function with it as well as any forward declarations of the class and instance init functions.
Currently, gnome-games will not build for me. I did a fresh checkout from CVS, but when I build I get hundreds of "error: template with C linkage".
Created attachment 38998 [details] [review] Proposed patch. Here is one patch for blackjack and libgames-support. This patch replaces games_frame_get_type() with a G_DEFINE_TYPE macro. (I figured out my compile problem. Recent gcc 4 changes to gtk+ broke the compile of c++ programs.)
I have just applied the patch to my master copy and it should be in CVS later tonight. Thanks a lot for putting all this effort in (I'm saying this for all the patches you have filed). It is the little details like these that add the final polish to a user interface. As the maintainer there always seem to be more important bugs to chase, and I never get around to these things. You have saved me a lot of time and effort. One minor detail, and it is too late for the patches you have already filed, but could you please add ChangeLog entries describing what you have changed. Various maintainers have different views on whether they are needed with a patch. I prefer the submitter to describe the changes in their own words (and I feel it looks better in terms of giving you credit rather than me saying such-and-such submitted a patch to do blah). In emacs use C-x 4 a to make an entry.
Callum, Thanks for reviewing my patches. ChangeLogs will be included in my next round of proposed fixes. I do believe I have fixed all the various dialogs in gnome-games. What you receive today should be the last flood of patches.
Fortunately patches like these are easy to review. Thanks again for all the hard work.
This bug is being reassigned to the "general" component so we can close the blackjack bugzilla component. Apologies for the mass email!