GNOME Bugzilla – Bug 172667
Several HIG regressions
Last modified: 2005-04-06 00:49:26 UTC
The following commit introduced several HIG regressions in the preference dialog. Please see http://developer.gnome.org/projects/gup/hig/. 2005-04-04 Carlos Garcia Campos <carlosgc@gnome.org> * cpufreq-applet.schemas.in: Add selector_mode key for configuring the frequency selector drop down menu * cpufreq-preferences.glade: Add frequency selector configuration * src/cpufreq-applet.[ch]: * src/cpufreq-monitor-protected.h: * src/cpufreq-monitor-sysfs.[ch]: * src/cpufreq-monitor.[ch]: * src/cpufreq-popup.c: * src/cpufreq-prefs.c: Add support to change the governor in the frequency selector drop down menu. Fixes #164581
By the way, the original HIG changes are found in bug #157913.
Why is better to use labels with spaces instead of alignments?
The short answer is spacing and alignment. Notice that in your redesign there is not 12 pixels of white space around the border of the dialog. There should also be 12 pixels between the action area and the vbox of the dialog. Now, the controls do not line up on the right and left side of the dialog. Also, there should be 18 pixels between each categories. And, a colon ":" should be appended to labels preceeding a control. You should read this link: http://developer.gnome.org/projects/gup/hig/2.0/design-window.html#window-layout-spacing You might want to read this link, too: http://bugzilla.gnome.org/show_bug.cgi?id=163850 Thanks.
Created attachment 39719 [details] A screenshot Ok, here is the current design (not committed yet), I think it's now a HIG compliant dialog. is it ok now? Thank you for your comments.
This looks much better. Unfortunately, glade frames add an extra pixel around their border; and, the frame labels are displayed in a washed out bold typeface. But, these issues are not of cpufreq's concern. Like I said, it looks much better. If you apply your UI changes, you can close this bug. Thanks.
Thanks Carlos!