After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144500 - When desktop_is_home_dir, file dialogs still show "Desktop"
When desktop_is_home_dir, file dialogs still show "Desktop"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.6.x
Other Linux
: Normal normal
: Small feature
Assigned To: gtk-bugs
Federico Mena Quintero
: 466093 496245 516280 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-06-16 21:27 UTC by Francesco Gigli
Modified: 2013-05-24 06:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Screenshot of the problem (23.32 KB, image/png)
2008-01-23 10:53 UTC, David Prieto
  Details
Skip Desktop if it equals the home folder (756 bytes, patch)
2008-10-10 13:59 UTC, Christian Dywan
committed Details | Review

Description Francesco Gigli 2004-06-16 21:27:12 UTC
If the "desktop_is_home_dir" is false all file dialogs (open/save) will still
show the "Desktop" Link even if it's pointless since ~/Desktop doesn't exists
(or, at least, is not used).

(submitting to nautilus, dunno if it the really rigth place for this)
Comment 1 Sebastien Bacher 2005-02-13 01:22:44 UTC
That's fileselector issue. There is a similar one for the single/double click
mode (#121113). Reassigning.
Comment 2 Thomas Winwood 2006-02-13 23:32:07 UTC
Isn't this a dupe of bug 324631?
Comment 3 Sebastien Bacher 2006-09-14 16:30:30 UTC
Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/gtk+2.0/+bug/60384
Comment 4 Germán Poo-Caamaño 2007-09-25 19:26:57 UTC
Thomas, it's not a dupe.

I reported a new one (bug 480340), which happens with 'main-menu' and 'menubar' applets.  Both of them still show the 'Desktop' when desktop_is_home_dir is set.
Comment 5 David Prieto 2008-01-23 10:53:07 UTC
Created attachment 103537 [details]
Screenshot of the problem

I have this too:

http://ubuntuforums.org/showthread.php?p=4190216#post4190216

"I set my Desktop to be the same as my home folder (you know, in gconf-editor) but when the open / save dialog appears, both folders appear. The Desktop one does nothing, it only redirects to my home again, and I would like it not to show"
Comment 6 jhnphm 2008-05-22 01:04:54 UTC
I also have this problem. Strangely, it only shows up when folders that aren't owned by an account are under /home  (I have /home on a seperate partition). 
Comment 7 jhnphm 2008-05-22 01:07:33 UTC
Quite odd, after moving the directories back under /home, the problem still is gone. 
Comment 8 Yevgen Muntyan 2008-09-10 05:28:26 UTC
*** Bug 516280 has been marked as a duplicate of this bug. ***
Comment 9 Yevgen Muntyan 2008-09-10 05:28:40 UTC
*** Bug 496245 has been marked as a duplicate of this bug. ***
Comment 10 Christian Dywan 2008-10-10 13:59:50 UTC
Created attachment 120337 [details] [review]
Skip Desktop if it equals the home folder

This patch makes the file chooser skip the Desktop shortcut if the folder equals the user's home folder.
Comment 11 Carlos Garnacho 2008-10-10 14:45:58 UTC
(In reply to comment #10)
> Created an attachment (id=120337) [edit]
> Skip Desktop if it equals the home folder
> 
> This patch makes the file chooser skip the Desktop shortcut if the folder
> equals the user's home folder.
> 

The patch looks quite correct to me from a XDG point of view, unfortunately this isn't enough IMHO, since the desktop_is_home_dir GConf key is quite older, and probably what most users modify since at least there's a GUI for it.

Another possibility would be to convince nautilus hackers to deprecate that key in favour of XDG user dirs.

Also, I'm thinking that maybe users would appreciate more to have a "Desktop" shortcut than a "home" one if both are the same, since the latter is more meaningless and doesn't have a visual representation as "Desktop" does. Although this probably differs with nautilus' behavior...
Comment 12 Christian Dywan 2008-10-10 15:12:44 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > Created an attachment (id=120337) [edit]
> > Skip Desktop if it equals the home folder
> > 
> > This patch makes the file chooser skip the Desktop shortcut if the folder
> > equals the user's home folder.
> > 
> 
> The patch looks quite correct to me from a XDG point of view, unfortunately
> this isn't enough IMHO, since the desktop_is_home_dir GConf key is quite
> older, and probably what most users modify since at least there's a GUI for
> it.
> 
> Another possibility would be to convince nautilus hackers to deprecate that
> key in favour of XDG user dirs.

Maybe it would be possible to set the Desktop folder XDG style if desktop_is_home_dir is set, and then deprecate it. That's going to be a follow-up bug in Nautilus.

> Also, I'm thinking that maybe users would appreciate more to have a "Desktop"
> shortcut than a "home" one if both are the same, since the latter is more
> meaningless and doesn't have a visual representation as "Desktop" does.
> Although this probably differs with nautilus' behavior...

I would think, given that Home is kind of a metaphor set in stone even outside any desktops, and since it's topmost in the shortcuts/ places, Home is far more important.
And it would probably feel weird with Home being in all applications, to not see it in the shortcuts.
I see your "visual" aspect, Desktop being a big window with icons on it. That doesn't weigh as much as the other points I mentioned, though - from my point of view.
Comment 13 Matthias Clasen 2008-12-12 07:05:33 UTC
> Maybe it would be possible to set the Desktop folder XDG style if
> desktop_is_home_dir is set, and then deprecate it. That's going to be a
> follow-up bug in Nautilus.

I could be mistaken, but I thought nautilus already does that ?
Comment 14 Matthias Clasen 2009-01-23 06:00:59 UTC
        * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Skip
        Desktop if it equals the home folder.
Comment 15 Timothy Arceri 2013-05-24 06:43:23 UTC
*** Bug 466093 has been marked as a duplicate of this bug. ***