GNOME Bugzilla – Bug 126284
Suggestion: keyboard shortcuts
Last modified: 2012-11-14 01:33:40 UTC
Would it be possible to add keyboard shortcuts for turning the dices into pumpkins and back as well as rolling the dices? Perhaps the number keys to (un)tag and RETURN or SPACE to roll?
Yeah, this needs to be done. In fact there needs to be keyboard short-cuts in a lot more of the games, for accessibility purposes if nothing else.
I'm hijacking this bug to make it a running list of all gnome-games that require keyboard functionality. The list is currently: aisleriot blackjack gataxx glines gnomine gnotravex gnotski gtali iagno mahjongg same-gnome
Gtali has noew been done (as per your suggestion) in CVS. This leaves: aisleriot blackjack gataxx glines gnomine gnotravex gnotski iagno mahjongg same-gnome
Blackjack has some. Though they are not documented, configurable, or possibly even intuitive. Currently: switch (key) { case KEY_S : bj_hand_stand (); break; case KEY_H : bj_hand_hit_with_delay (); break; case KEY_D : bj_hand_double (); break; case KEY_P : bj_hand_split (); break; case KEY_R : bj_hand_surrender (); break; case KEY_ENTER : bj_hand_new_deal (); break; default: break; } It should be simple to make these configurable via the preferences dialog.
Configuration is not important. Keeping them simple and semi-intuitive is (although mnemonic keys will always fail i18n so we can't ever win). If you could document those keys we can happily remove blackjack from the list.
Some (crude) documentation has been added to Blackjack in CVS.
If no one has started on these yet, I'll be happy to add keyboardability to glines, gnomine and iagno. Proposed functionality: arrow and numpad keys to move around, space (and also num5?) is the action button. When one of the movement keys is pressed, a selection rectangle appears; clicking on the game field with the mouse hides it. In gnomine, M or Insert (?) toggles the "mine here" flag.
Go for it Anton. I'm doing same-gnome as part of the rewrite and the behaviour there is going to be the same as what you propose. For gnomine it might be better to use space for toggle and enter for reveal. i.e. use the big keys. Also putting the binding on the keypad keys is definitely a good idea (it can't be just the keypad though because laptops often don't have them in any meaningful sense). If you do work on iagno, it might be better to have a look at gataxx instead. At some point I want to merge the two code-bases and gataxx has better encapsulation of the drawing functions.
Created attachment 32436 [details] [review] glines keyboardability patch. Movement keys are arrows, home, end, pgup, pgdn and their keypad counterparts; space and Enter have the same effect as clicking on a cell. I'm no artist (nor a GDK guru), so the keyboard selection is indicated by an ugly white rectangle around a cell. Make sure you fix bug #154982, or it will render incorrectly in the rightmost column and the bottommost row of cells.
i was thinking that if Pause is used for Pause Game then End should be used for End Game to keep things consistant (I only have Gnome 2.6 instead of 2.8 on this machine so please forgive me if this has been changed already, but I noticed a while ago that Gnometris in 2.8 didn't have a keybinding for End Game). If possible I'd like for Ctrl+W to also be possible making "End Game" analgous to "Close Document" in more file orientated applications, but i think consistancey with the other games is a more important priority.
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs. Filter on "SUN A11Y SPAM" to ignore.
I have finally applied Anton's patch (sorry about the delay Anton, thank Richard for prodding me). I am also working on same-gnome keyboard support in the rewrite. So the list is now: aisleriot gataxx gnomine gnotravex gnotski iagno mahjongg same-gnome (half-done)
Same Gnome keyboard support is now implemented. The list is now: aisleriot gataxx gnomine gnotravex gnotski iagno mahjongg
Richard pointed to this bug as covering my request in bug 315489 suggesting there was a need to have a keyboard shortcut (preferably made clearly visible using a a menu item) to deal the next card from the Foundation. Adding this comment to try and help prevent the issue being forgotten.
*** Bug 316220 has been marked as a duplicate of this bug. ***
Bug #315489 and Bug #316220 (mentioned in Comment #14 and Comment #15 ) are things we would probably do anyway when it comes time to implement Aisleriot keyboard navigation.
*** Bug 339070 has been marked as a duplicate of this bug. ***
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Aisleriot is done; that leaves the following games: gataxx gnomine gnotravex gnotski iagno mahjongg
Re-assigning to new default owner.
glchess bug #565585
What keyboard shortcuts would people like to see in gnotravex? It seems like an entirely mouse driven game.
Dan, gnotravex should be playable without a mouse (mainly for a11y reasons). You should be able to move between the pieces with arrow and tab keys and select them with space or enter. When selected draw the piece so it looks above the board (offset and maybe drop shadow). Then move to designated place and drop with space/enter (escape to cancel).
Please open against each game if still required.