After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 154982 - Drawing area is one pixel too small
Drawing area is one pixel too small
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: glines
2.7.x
Other All
: Normal minor
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2004-10-09 19:45 UTC by Anton Gavrilov
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix bug #154982, incorrect drawing of rightmost and bottom grid lines (1012 bytes, patch)
2004-10-09 19:50 UTC, Anton Gavrilov 		none Details | Review

Description Anton Gavrilov 2004-10-09 19:45:08 UTC 
Paolo's drawing improvements* add border grid lines at the right and the bottom
of the drawing area;  but because the size of the drawing area is always a
multiple of FIELDSIZE, the rightmost and bottom grid lines appear shifted one
pixel to the left and up, respectively.

* improvements you say?  draw_grid() repaints the entire grid whenever a
(possibly tiny) part of the drawing area needs to be updated!
Comment 1 Anton Gavrilov 2004-10-09 19:50:20 UTC 
Created attachment 32431 [details] [review]
Fix bug #154982, incorrect drawing of rightmost and bottom grid lines

The change in configure_even_callback is a matter of taste;  it provides
identical results due to integer division.
Comment 2 Anton Gavrilov 2004-10-09 21:39:55 UTC 
Oh, maybe use GRID_LINE_WIDTH instead of the 1's to make the code more
maintainable and self-explanatory?
Comment 3 Callum McKenzie 2004-10-11 06:50:08 UTC 
I've simplified the patch even further, the xboxsize and yboxsize code is from
before games_gridframe so I just set boxsize directly off the width since both
should be identical. 

Technically gnect is also affected, but it hides it fairly well so I'm not going
to fix it. (The fix doesn't seem simple since it implies negative padding.)