After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115549 - Delete key causes entire object to be deleted when editing text
Delete key causes entire object to be deleted when editing text
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
0.91
Other All
: Normal major
: 0.97
Assigned To: Dia maintainers
Dia maintainers
: 118831 123210 144195 153451 304749 323992 325322 329599 334130 342130 461682 497349 518790 528737 580235 584757 (view as bug list)
Depends on:
Blocks: 145384
 
 
Reported: 2003-06-19 15:20 UTC by Greg Watson
Modified: 2009-06-03 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Greg Watson 2003-06-19 15:20:00 UTC
In Win32 version there is a bug that when you try to edit text inside a
object and press the delete key.  The program deletes the entire object
because it is still selected instead of a single letter.  This bug does not
exist on Linux versions.

Version test: 0.91

How to reproduce:
Create a new object, double click on object to enter text.
Type a few letters, move back with arrors or mouse and try to delete a
letter.  

Result: 
Entire object deleted.

Expected:
Only one letter to be deleted.

Notes:
It appears that the object remains selected after double click and that is
the cause of it being deleted.  Maybe the object should be unselected on
edit text?
Comment 1 Alan Horkan 2003-06-24 20:51:27 UTC
chaging OS to Windows

Umm yeah the text widget sucks, i think Lars has something in mind to
completely replace it.  

i get this too, as a workaround backspace works alright
Comment 2 Lars Clausen 2003-06-24 21:27:34 UTC
Yes, I do indeed intend to replace the current hacky input system with a GtkTextView 
derivative.  This would also allow such nice things as editing different fields of an 
object in the diagram and tabbing between fields.  Volunteers to help/discuss UI 
issues would be greatly appreciated.  This is however a big enough change that I 
won't be doing it for 0.92.
Comment 3 Hans Breuer 2003-12-14 11:38:38 UTC
*** Bug 118831 has been marked as a duplicate of this bug. ***
Comment 4 Hans Breuer 2003-12-14 11:40:20 UTC
by no means OS specific, see bug #11831
Comment 5 Hans Breuer 2004-01-18 13:49:54 UTC
*** Bug 123210 has been marked as a duplicate of this bug. ***
Comment 6 Pascal 2004-05-10 13:12:04 UTC
this bug is still present in dia 0.93 (mdk linux cooker version)... 
Comment 7 Lars Clausen 2004-05-15 23:21:00 UTC
Yes.  The rework of text entry mentioned above is in the works for 0.94.
Comment 8 Hans Breuer 2004-10-30 15:47:36 UTC
Del still deletes the text object on Linux and Win32
Comment 9 Lars Clausen 2004-10-31 17:57:30 UTC
Indeed.  Done some upgrades on the text entry system, but even 0.95 won't have
all text entry done in embedded GtkEntry widgets (unless somebody suddenly hacks
it up:).

Underlying problem, for those interested, is that there is no difference between
an object being selected and its text being edited, it is the same state.  Until
that changes, Del will work wrongly for either deleting objects or deleting text.
Comment 10 Hans Breuer 2004-11-07 10:56:36 UTC
*** Bug 144195 has been marked as a duplicate of this bug. ***
Comment 11 Lars Clausen 2005-02-28 16:34:41 UTC
*** Bug 153451 has been marked as a duplicate of this bug. ***
Comment 12 Alan Horkan 2005-05-19 14:33:54 UTC
*** Bug 304749 has been marked as a duplicate of this bug. ***
Comment 13 Erik Wasser 2005-10-19 11:15:20 UTC
Mmmh... when will the new text widgets be ready?

This 'delete' feature is eh... eh... quite different from my usability.
Comment 14 Hans Breuer 2005-12-13 20:38:43 UTC
*** Bug 323992 has been marked as a duplicate of this bug. ***
Comment 15 Hans Breuer 2005-12-30 19:41:50 UTC
*** Bug 325322 has been marked as a duplicate of this bug. ***
Comment 16 Hans Breuer 2006-01-02 18:52:11 UTC
Although this may look like a choice between pest and cholera:
By reassigning the old hotkey (ctrl-D) to Edit/Delete you can
have back the feature of Delete working in text edits. All
the original code is still there.
Comment 17 Lars Clausen 2006-02-02 18:03:43 UTC
*** Bug 329599 has been marked as a duplicate of this bug. ***
Comment 18 Hans Breuer 2006-03-10 20:58:52 UTC
*** Bug 334130 has been marked as a duplicate of this bug. ***
Comment 19 Hans Breuer 2006-05-20 09:42:11 UTC
*** Bug 342130 has been marked as a duplicate of this bug. ***
Comment 20 Claudio Saavedra 2007-07-30 04:31:43 UTC
*** Bug 461682 has been marked as a duplicate of this bug. ***
Comment 21 Claudio Saavedra 2007-07-30 04:33:02 UTC
Just because I typed this in another bug I copy it here.

"Steps to reproduce:

- Create a text object in the diagram. 
- Write some text.
- Move back with arrow keys to the middle of the text.
- "pretend to remove some text to the right of the cursor" by pressing the 
  del key.
- See how the text you typed disappear.

For a long time I've thought of this as a "feature", but it's been too long and
I still have a hard time every time I forget about it and loose text. Please,
while editing the text in an object, use the Del key as expected!"

What's the status of this?
Comment 22 Hans Breuer 2007-09-25 22:27:01 UTC
There is no reason for this bug to be in NEEDINFO. In fact a lot of info is provided. Mode discussion on the mailing list:
http://mail.gnome.org/archives/dia-list/2007-September/msg00078.html

But IMHO just reverting to ctrl+D is not really an option nowadays, although I suggested it 20 month ago ;)
Comment 23 Hans Breuer 2007-10-14 16:59:12 UTC
Finally the real solution hit SVN ;) Delete used for text editing (when in text editing mode) and to delete objects otherwise:

2007-10-14  Hans Breuer  <hans@breuer.org>

	Next stab on dedicated text edit mode:
	* app/textedit_tool.[ch] app/tool.[ch] app/cursors.[ch] 
	app/interface.c app/Makefile.am app/makefile.msc data/display-ui.xml 
	data/integrated-ui.xml data/popup-ui.xml : text edit mode 
	reflected in toolbox, it is too different from normal modification
	* app/diagram.c app/menu.c : make Cut, Copy, Paste, Delete 
	and Duplicate menu entries insensitive when text is edited
	* app/pixmaps/textedit.png : an ugly icon
	* app/create_object.c app/disp_callbacks.c : deal with transitions 
	from one tool to to the other
	* app/textedit.[ch](textedit_activate_object): tell if editing started
Comment 24 Hans Breuer 2007-11-16 19:55:28 UTC
*** Bug 497349 has been marked as a duplicate of this bug. ***
Comment 25 Hans Breuer 2008-02-26 19:44:04 UTC
*** Bug 518790 has been marked as a duplicate of this bug. ***
Comment 26 Hans Breuer 2008-04-18 22:08:14 UTC
*** Bug 528737 has been marked as a duplicate of this bug. ***
Comment 27 Hans Breuer 2009-04-25 18:25:09 UTC
*** Bug 580235 has been marked as a duplicate of this bug. ***
Comment 28 Hans Breuer 2009-06-03 19:20:03 UTC
*** Bug 584757 has been marked as a duplicate of this bug. ***