GNOME Bugzilla – Bug 109412
Can zoom in, but not out
Last modified: 2005-07-09 18:59:19 UTC
EOG seems to be doing something strange with the zoom out ie. '='/'+'. I've tracked what's getting emitted using xev, KP_Add and KP_Subtract are working fine, but when I move off the numerical keypad, only 'minus' works and not 'equal' or 'plus'. Something seems to be eating the 'equal' :(
Should probably implement BonoboZoomable too ;)
I never quite understand why '=' should zoom out. I mean, if you zoom in with '+', what is the logical key to zoom out? I think it's '-'. That is how it's implemented in Eog. Additionaly the '=' key can be accessed on german keyboards only with Shift+0. The '=' switch to 1:1 zoom. I don't intend to change this keyboard navigation behaviour. And what do you mean with 'should implement BonoboZoomable'? Eog was one of the first apps which implemented this interface and it does until now. Where is the problem?
view-as-collection needs to implement BonoboZoomable. I think the other problems Gman had was with view-as-collection too.
Ah, this makes more sense. Changing the component to 'collection' then.
> I never quite understand why '=' Jens, On an American/British keyboard = is the on the same key as + This has been discussed in detail elsewhere, in HIG bug report I think. I proposed that both + and = should zoom in, and that + should be the labelled shortcut. I'll bet that most ordinary users wont even think about the fact that plus + is in fact "shift =" and will just hit the button with plus + on it. I dont know the bug nubmer offhand (ill try and find it later) but the HIG really needs to be changed, as you can understand using = really sucks for non American/British keyboards.
Notes: Changed to GNOMEVER2.3 from 2.2 keyword. Added bugsquad and keynav keywords
Could not replicate error, everything worked. Ctrl++ Zooms in, Ctrl+- Zooms out and Ctrl+= brings it to the normal size and + and - keys in Num pad Zooms in and Zooms out in eog collection view
Martin, the problem is that Gman expected hitting the key labelled "+=" to work however he would have needed to shift the key labelled "+=" to get it to work. This is exactly what I would expect too which is why I have recommended the HIG be changed so and recommend that both Ctrl + and Ctrl = should Zoom and Ctrl 0 (zero) should reset the View to Normal (because Mozilla does it and because 0 is conveniently located just left of the minus - and = keys and it is not being used for anything else).
That bug report I mentioned for a change in the Human Interface Guidelines. http://bugzilla.gnome.org/show_bug.cgi?id=132820 However to resolve the problem in this bug both +/= (or Ctrl +/=) would have to work for Zoom.
In the latest draft of the HIG, the recommendation is indeed for both Ctrl-Plus and Ctrl-Equals to work for Zoom in, and for Ctrl-Zero to be 'Normal size'. (I just haven't closed out Alan's bug yet as the recommendation hasn't really been reviewed by anyone else yet.) Anyway, in the meantime, Ctrl-plus and Ctrl-minus are working in the collection view for me, but Ctrl-= isn't, so unless this has been fixed in the past week or so I'm not sure we can close this yet :/
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs. Filter on "SUN A11Y SPAM" to ignore.
Created attachment 35812 [details] [review] This Patch reassigns the shortcut keys for Zoom In and Zoom Out
Why should we change the shortcut to <shift>-+ and <shift>-_, as the patch did? On my keyboard <shift>++ gives a *. AFAICS the only thing which must be handled is <Ctrl>-= to also zoom in. Everything else works as expected and in compliance to the HIG.
Created attachment 35880 [details] [review] The updated patch
Hi Jens Finke Reassigned shortcuts to 'Zoom In' as 'ctrl+=' and 'Zoom Out' as 'ctrl+-' and 'ctrl+0' for Normal. This is ok I think :)
From the HIG (http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#standard-shortcuts): Zoom In Ctrl-Plus Zoom in on the document Zoom Out Ctrl-Minus Zoom out of the document Normal Size Ctrl-0 Restore to zoom level to normal size (generally 100%) The problem here is, that with some keyboards '+' is only accessable by pressing the shift key. Without shift it gives the '=' sign. So the solution proposed above is to let Ctrl-Plus and Ctrl-Equal work for zooming in, but only show Ctrl-Plus as a shortcut. This way it doesn't matter if people use shift or not. BTW: On german layout keyboards the '+' and '=' signs are on different keys and only '=' requires the shift key.
Created attachment 35890 [details] [review] The patch reassigns shortcut for Normal Size to ctrl+0
ping
You really shouldn't do things like that, I expect it more likely to annoy than encourage the EOG developer but I do also wonder why EOG patches dont get a faster response. Now that Gnome 2.10 is out hopefully someone can commit this? Pretty please?
*** Bug 305822 has been marked as a duplicate of this bug. ***
Created attachment 48177 [details] [review] Patch using Ctrl+0 for Normal Size and Ctrl+= for zoom in I thought I also add the patch of Bug 305822 to this bug report. My patch corrects the Normal Size accelerator and sets it to Ctrl+0 but furthermore also add Ctrl+= as an accelarator for Zoom In. Ctrl+= for Zoom In is already commited to Evince ( bug 305961 ), Nautillus ( bug 306225, Alan Horkan of the usability teams argues overthere that it is a good idea to also add Ctrl+= as an accelerator for zoom in) and gthumb bug 302753
Patch applied. Thanks Jaap, etc.
Thanks for applying it. Nice to see that eog has a maintainer again