After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 305961 - Make = and Ctrl+= do zoom in
Make = and Ctrl+= do zoom in
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-30 20:44 UTC by Jaap A. Haitsma
Modified: 2005-06-17 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.50 KB, patch)
2005-05-30 20:44 UTC, Jaap A. Haitsma
needs-work Details | Review
Patch including the comments of Nickolay (1.86 KB, patch)
2005-05-31 17:32 UTC, Jaap A. Haitsma
none Details | Review
Patch (1.89 KB, patch)
2005-05-31 18:50 UTC, Nickolay V. Shmyrev
none Details | Review

Description Jaap A. Haitsma 2005-05-30 20:44:15 UTC
On a laptop you have to do the + by holding Shift and then doing  "="/"+" key.
So it's handy to have = and Ctrl+= also do zooming. Among other firefox does this. 

Patch coming
Comment 1 Jaap A. Haitsma 2005-05-30 20:44:43 UTC
Created attachment 47050 [details] [review]
patch
Comment 2 Nickolay V. Shmyrev 2005-05-30 20:48:35 UTC
This patch needs work. You should disable = action in entry. check ev-window once again, there was such function.
Comment 3 Marco Pesenti Gritti 2005-05-30 21:59:31 UTC
I'm not that convinced about this one. It seem very keyboard/country specific.

Are there gnome apps doing it?
Comment 4 Nickolay V. Shmyrev 2005-05-30 22:13:49 UTC
gpdf, for example.

Although HIG says nothing about this. It just requires Ctrl+plus for zooming.
But I think we can help users. It really seems strange that zoom in requires
shift, while zoom out doesn't
Comment 5 Nickolay V. Shmyrev 2005-05-30 22:17:18 UTC
And nautilus too
Comment 6 Jaap A. Haitsma 2005-05-31 07:51:57 UTC
gthumb uses "=" as well. It does not use the the Ctrl+ versions yet. But I filed
a patch for that to also add the Ctrl+ shortcuts bug 302753
Comment 7 Jaap A. Haitsma 2005-05-31 17:32:43 UTC
Created attachment 47069 [details] [review]
Patch including the comments  of Nickolay

Nikolay, is this what you meant in your comment?
Comment 8 Nickolay V. Shmyrev 2005-05-31 17:35:16 UTC
Right, but there is no need to add Ctrl+=, just equal would be fine 
:)
Comment 9 Jaap A. Haitsma 2005-05-31 18:02:18 UTC
Hmmm, I'm afraid I don't understand. Ctrl++ and + are also there. So why not =
and Ctrl+= .Ctrl+= is handy for the people who would try to do Ctrl++ but
"forget" to use the Shift to get the "+"
Comment 10 Nickolay V. Shmyrev 2005-05-31 18:50:11 UTC
Created attachment 47071 [details] [review]
Patch

Here is correct patch (i believe :) ) We disable Equal key in entry to let user
type = there. But there is no need to disable Ctrl+Equal.

We'll commit it if Bryan Clark say so.
Comment 11 Jaap A. Haitsma 2005-05-31 20:15:46 UTC
OK, thanks I understand now.
Comment 12 Marco Pesenti Gritti 2005-06-15 09:21:42 UTC
Bryan, should this go in or we WONTFIX this?
Comment 13 Jaap A. Haitsma 2005-06-15 10:30:20 UTC
Alan Horkan of the usibility team thinks adding Ctrl+= for zoom in is a good idea.
See bug 306225
The patch overthere got applied to nautilus
Comment 14 Bryan W Clark 2005-06-15 12:46:43 UTC
The Ctrl+= seems fine to add as a keyboard hack, but I've been reluctant to
allow the other single key ones; and that hasn't changed ;-).  So I'd say go
ahead with the Ctrl+= but not the single key.

Maybe later I'll change my mind and allow all those single key functions, but it
really seems like bloat to me since we enable to consistant behavior like we're
supposed to.
Comment 15 Marco Pesenti Gritti 2005-06-17 09:58:56 UTC
Cut out the equal only part and committed. Fixed for the ctrl part, WONTFIX for
the other.